Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Understand why the tests are failing with httpx==0.28.1 #52

Open
LeoGrin opened this issue Dec 11, 2024 · 3 comments
Open

BUG - Understand why the tests are failing with httpx==0.28.1 #52

LeoGrin opened this issue Dec 11, 2024 · 3 comments

Comments

@LeoGrin
Copy link
Collaborator

LeoGrin commented Dec 11, 2024

See #51 and #49 for context. For now we enforce httpx==0.27.2 but we should be able to use newer version in the future.

@LeoGrin
Copy link
Collaborator Author

LeoGrin commented Dec 11, 2024

Only looked quickly but this may be related encode/httpx#3433

@mert-kurttutan
Copy link

mert-kurttutan commented Feb 26, 2025

Hi, @LeoGrin
This is due to the handling of spaces in httpx: Two relevant commits:

Two potential solutions:

  • change the test assertions so that it handles this based on the version of httpx available.
  • some other library that is consistent with this, e.g. requests

I prefer the 1st solution since the 2nd is longer and inconsistency in url encoding only affect this test result

@mert-kurttutan
Copy link

The responsible change is about the function urlencode
/~https://github.com/encode/httpx/pull/2543/files#diff-f1eb4e8fbdbce3bb7dcc3ecb662f690f9443599de8b172513ddb65de6b1d7c73
where they changed it between their own version and the one from standard library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants