Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop capturing events on debug instances #1518

Closed
paolodamico opened this issue Aug 26, 2020 · 4 comments · Fixed by #1519 or #1539
Closed

Stop capturing events on debug instances #1518

paolodamico opened this issue Aug 26, 2020 · 4 comments · Fixed by #1519 or #1539
Assignees
@paolodamico
Labels
enhancement New feature or request

Comments

@paolodamico
Copy link
Contributor

When DEBUG = 1 stop sending events to PostHog (via posthoganalytics) as to remove noise from test installations. Perhaps we can just send a boot / install event with a property that indicates if it's running on debug to track the number of test installations.

CC @yakkomajuri
@paolodamico paolodamico added the enhancement New feature or request label Aug 26, 2020
@paolodamico paolodamico self-assigned this Aug 26, 2020
@yakkomajuri
Copy link
Contributor

Yeah I would generally be for this as well, unless there's something I'm missing. It's nice to know someone deployed in DEBUG mode (i.e. hey new contributor!), but otherwise that just bloats the db with noise.

@Twixes Twixes linked a pull request Aug 26, 2020 that will close this issue
Improve tracking of development instances (resolves #1518) #1519
Merged
@Twixes
Copy link
Member

Twixes commented Aug 26, 2020 •
edited
Loading

I made a solution that should work, except on completely clean-slate instances that haven't gone through setup yet. Take a look at the PR.

Twixes added a commit that referenced this issue Aug 28, 2020
@Twixes
Improve tracking of development instances (resolves #1518) (#1519)
8c1753c 
* Improve postcss.config.js style

* Improve dev instance analytics

* Use hashed MAC address as distinct ID is DEBUG mode

* Improve code style very slightly
@paolodamico
Copy link
Contributor Author

Re-opening this as development instances are still sending frontend events to app.posthog.com, JS analytics should be disabled too.

@paolodamico paolodamico reopened this Sep 1, 2020
@Twixes Twixes mentioned this issue Sep 1, 2020
Merged
@Twixes
Copy link
Member

Twixes commented Sep 1, 2020

That's a simple enough change #1539.

@Twixes Twixes linked a pull request Sep 1, 2020 that will close this issue
Disable the PostHog JS snippet in DEBUG mode (closes #1518) #1539
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paolodamico paolodamico

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@Twixes @paolodamico @yakkomajuri