Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note to report issues upstream with mwe #1599

Open
unalmis opened this issue Feb 20, 2025 · 1 comment
Open

note to report issues upstream with mwe #1599

unalmis opened this issue Feb 20, 2025 · 1 comment
Assignees
Labels
dependencies Issue related to libraries we depend on and how we interface with them P2 Medium Priority, not urgent but should be on the near-term agend

Comments

@unalmis
Copy link
Collaborator

unalmis commented Feb 20, 2025

In #1522 and #1360 it was observed that the matrix give wrong results when the tensor's size is large. Both these operations are numerically stable in these cases. For now I fixed these issues by using a different approach and/or chunking the computation. This is a note to self to simplify the examples and report to upstream repositories.

@unalmis unalmis added the P1 Lowest Priority, will get to eventually label Feb 20, 2025
@unalmis unalmis self-assigned this Feb 20, 2025
@unalmis unalmis changed the title note to make minimal working example issues upstream note to report issues upstream with mwe Feb 20, 2025
@unalmis unalmis added dependencies Issue related to libraries we depend on and how we interface with them P3 Highest Priority, someone is/should be actively working on this and removed P1 Lowest Priority, will get to eventually labels Feb 20, 2025
unalmis added a commit that referenced this issue Feb 23, 2025
@unalmis
Copy link
Collaborator Author

unalmis commented Feb 23, 2025

Here is one example. The test_harmonic_general test fails unless chunk_size is reduced.

marks=pytest.mark.xfail(

The reason it fails is because the matrix multiplication in the line linked below is performed incorrectly when chunk_size is large.

return jnp.real(vander @ f)

@unalmis unalmis added P2 Medium Priority, not urgent but should be on the near-term agend and removed P3 Highest Priority, someone is/should be actively working on this labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issue related to libraries we depend on and how we interface with them P2 Medium Priority, not urgent but should be on the near-term agend
Projects
None yet
Development

No branches or pull requests

1 participant