Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issue about crop_op and reshape_op #6533

Closed
chengduoZH opened this issue Dec 12, 2017 · 2 comments
Closed

Some issue about crop_op and reshape_op #6533

chengduoZH opened this issue Dec 12, 2017 · 2 comments
Assignees

Comments

@chengduoZH
Copy link
Contributor

chengduoZH commented Dec 12, 2017

Currently, the shape is as an attribute in the crop_op and reshape_op, I think it's unwise.
Imagine that when these op are used to process text data, and the last batch of the data is less than batch_size, reshape_op will go wrong. The case is here.
So, in my opinion, shape should be used as a OP input.
@kuke @wanghaoshuang

@kuke
Copy link
Contributor

kuke commented Dec 12, 2017

OK, I will move shape to the input of reshape_op.

@shanyi15
Copy link
Collaborator

您好,此issue在近一个月内暂无更新,我们将于今天内关闭。若在关闭后您仍需跟进提问,可重新开启此问题,我们将在24小时内回复您。因关闭带来的不便我们深表歉意,请您谅解~感谢您对PaddlePaddle的支持!
Hello, this issue has not been updated in the past month. We will close it today for the sake of other user‘s experience. If you still need to follow up on this question after closing, please feel free to reopen it. In that case, we will get back to you within 24 hours. We apologize for the inconvenience caused by the closure and thank you so much for your support of PaddlePaddle Group!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants