GCC12: mismatched-new-delete error in custom_device.cc #42908

bulvara · 2022-05-20T20:19:02Z

bug描述 Describe the Bug

When compiling PaddlePaddle with GCC 12.1 several mismatched-new-delete errors arise in custom_device.cc of the Phi backend:

n file included from /usr/include/c++/12.1.0/memory:76,
                 from ./Paddle/paddle/fluid/platform/enforce.h:52,
                 from ./Paddle/paddle/fluid/platform/device/custom/enforce_custom.h:19,
                 from ./Paddle/paddle/phi/backends/custom/custom_device.cc:15:
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = unsigned char]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = unsigned char; _Dp = std::default_delete<unsigned char>]' at /usr/include/c++/12.1.0/bits/unique_ptr.h:396:17,
    inlined from 'virtual void phi::CustomDevice::MemoryCopyP2P(const phi::Place&, void*, size_t, const void*, size_t, const phi::stream::Stream*)' at ./Paddle/paddle/phi/backends/custom/custom_device.cc:354:7:
/usr/include/c++/12.1.0/bits/unique_ptr.h:95:9: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
./Paddle/paddle/phi/backends/custom/custom_device.cc: In member function 'virtual void phi::CustomDevice::MemoryCopyP2P(const phi::Place&, void*, size_t, const void*, size_t, const phi::stream::Stream*)':
./Paddle/paddle/phi/backends/custom/custom_device.cc:351:54: note: returned from 'void* operator new [](std::size_t)'
  351 |         std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
      |                                                      ^
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = unsigned char]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = unsigned char; _Dp = std::default_delete<unsigned char>]' at /usr/include/c++/12.1.0/bits/unique_ptr.h:396:17,
    inlined from 'virtual void phi::CustomDevice::MemoryCopyP2P(const phi::Place&, void*, size_t, const void*, size_t, const phi::stream::Stream*)' at ./Paddle/paddle/phi/backends/custom/custom_device.cc:354:7:
/usr/include/c++/12.1.0/bits/unique_ptr.h:95:9: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
./Paddle/paddle/phi/backends/custom/custom_device.cc: In member function 'virtual void phi::CustomDevice::MemoryCopyP2P(const phi::Place&, void*, size_t, const void*, size_t, const phi::stream::Stream*)':
./Paddle/paddle/phi/backends/custom/custom_device.cc:351:54: note: returned from 'void* operator new [](std::size_t)'
  351 |         std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
      |                                                      ^
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = unsigned char]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = unsigned char; _Dp = std::default_delete<unsigned char>]' at /usr/include/c++/12.1.0/bits/unique_ptr.h:396:17,
    inlined from 'virtual void phi::CustomDevice::MemorySet(size_t, void*, uint8_t, size_t)' at ./Paddle/paddle/phi/backends/custom/custom_device.cc:446:5:
/usr/include/c++/12.1.0/bits/unique_ptr.h:95:9: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
./Paddle/paddle/phi/backends/custom/custom_device.cc: In member function 'virtual void phi::CustomDevice::MemorySet(size_t, void*, uint8_t, size_t)':
./Paddle/paddle/phi/backends/custom/custom_device.cc:443:52: note: returned from 'void* operator new [](std::size_t)'
  443 |       std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
      |                                                    ^
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = unsigned char]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = unsigned char; _Dp = std::default_delete<unsigned char>]' at /usr/include/c++/12.1.0/bits/unique_ptr.h:396:17,
    inlined from 'virtual void phi::CustomDevice::MemorySet(size_t, void*, uint8_t, size_t)' at ./Paddle/paddle/phi/backends/custom/custom_device.cc:446:5:
/usr/include/c++/12.1.0/bits/unique_ptr.h:95:9: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
./Paddle/paddle/phi/backends/custom/custom_device.cc: In member function 'virtual void phi::CustomDevice::MemorySet(size_t, void*, uint8_t, size_t)':
./Paddle/paddle/phi/backends/custom/custom_device.cc:443:52: note: returned from 'void* operator new [](std::size_t)'
  443 |       std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
      |                                                    ^
cc1plus: all warnings being treated as errors
make[2]: *** [paddle/phi/backends/custom/CMakeFiles/custom_device.dir/build.make:76: paddle/phi/backends/custom/CMakeFiles/custom_device.dir/custom_device.cc.o] Error 1

其他补充信息 Additional Supplementary Information

check out git master;

cmake
make

The text was updated successfully, but these errors were encountered:

paddle-bot-old · 2022-05-20T20:19:06Z

您好，我们已经收到了您的问题，会安排技术人员尽快解答您的问题，请耐心等待。请您再次检查是否提供了清晰的问题描述、复现代码、环境&版本、报错信息等。同时，您也可以通过查看官网API文档、常见问题、历史Issue、AI社区来寻求解答。祝您生活愉快～

Hi! We've received your issue and please be patient to get responded. We will arrange technicians to answer your questions as soon as possible. Please make sure that you have posted enough message to demo your request. You may also check out the API，FAQ，Github Issue and AI community to get the answer.Have a nice day!

ronny1996 · 2022-05-23T04:46:39Z

Please try compiling with the patch below

diff --git a/paddle/phi/backends/custom/custom_device.cc b/paddle/phi/backends/custom/custom_device.cc
index df757b2..6c74ebb 100644
--- a/paddle/phi/backends/custom/custom_device.cc
+++ b/paddle/phi/backends/custom/custom_device.cc
@@ -348,7 +348,7 @@ class CustomDevice : public DeviceInterface {
       }
     } else {
       if (!pimpl_->memory_copy_p2p) {
-        std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
+        std::unique_ptr<uint8_t> tmp(reinterpret_cast<uint8_t*>(new uint8_t[size]));
         MemoryCopyD2H(src_dev_id, tmp.get(), src, size);
         MemoryCopyH2D(dst_dev_id, dst, tmp.get(), size);
       } else {
@@ -440,7 +440,7 @@ class CustomDevice : public DeviceInterface {
       PADDLE_ENFORCE_CUSTOM_DEVICE_SUCCESS(
           pimpl_->device_memory_set(device, ptr, value, size));
     } else {
-      std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
+      std::unique_ptr<uint8_t> tmp(reinterpret_cast<uint8_t*>(new uint8_t[size]));
       memset(tmp.get(), value, size);
       MemoryCopyH2D(dev_id, ptr, tmp.get(), size);
     }

RexSi · 2022-12-29T16:35:36Z

bug描述 Describe the Bug

When compiling PaddlePaddle with GCC 12.1 several mismatched-new-delete errors arise in custom_device.cc of the Phi backend:

n file included from /usr/include/c++/12.1.0/memory:76,
                 from ./Paddle/paddle/fluid/platform/enforce.h:52,
                 from ./Paddle/paddle/fluid/platform/device/custom/enforce_custom.h:19,
                 from ./Paddle/paddle/phi/backends/custom/custom_device.cc:15:
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = unsigned char]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = unsigned char; _Dp = std::default_delete<unsigned char>]' at /usr/include/c++/12.1.0/bits/unique_ptr.h:396:17,
    inlined from 'virtual void phi::CustomDevice::MemoryCopyP2P(const phi::Place&, void*, size_t, const void*, size_t, const phi::stream::Stream*)' at ./Paddle/paddle/phi/backends/custom/custom_device.cc:354:7:
/usr/include/c++/12.1.0/bits/unique_ptr.h:95:9: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
./Paddle/paddle/phi/backends/custom/custom_device.cc: In member function 'virtual void phi::CustomDevice::MemoryCopyP2P(const phi::Place&, void*, size_t, const void*, size_t, const phi::stream::Stream*)':
./Paddle/paddle/phi/backends/custom/custom_device.cc:351:54: note: returned from 'void* operator new [](std::size_t)'
  351 |         std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
      |                                                      ^
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = unsigned char]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = unsigned char; _Dp = std::default_delete<unsigned char>]' at /usr/include/c++/12.1.0/bits/unique_ptr.h:396:17,
    inlined from 'virtual void phi::CustomDevice::MemoryCopyP2P(const phi::Place&, void*, size_t, const void*, size_t, const phi::stream::Stream*)' at ./Paddle/paddle/phi/backends/custom/custom_device.cc:354:7:
/usr/include/c++/12.1.0/bits/unique_ptr.h:95:9: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
./Paddle/paddle/phi/backends/custom/custom_device.cc: In member function 'virtual void phi::CustomDevice::MemoryCopyP2P(const phi::Place&, void*, size_t, const void*, size_t, const phi::stream::Stream*)':
./Paddle/paddle/phi/backends/custom/custom_device.cc:351:54: note: returned from 'void* operator new [](std::size_t)'
  351 |         std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
      |                                                      ^
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = unsigned char]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = unsigned char; _Dp = std::default_delete<unsigned char>]' at /usr/include/c++/12.1.0/bits/unique_ptr.h:396:17,
    inlined from 'virtual void phi::CustomDevice::MemorySet(size_t, void*, uint8_t, size_t)' at ./Paddle/paddle/phi/backends/custom/custom_device.cc:446:5:
/usr/include/c++/12.1.0/bits/unique_ptr.h:95:9: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
./Paddle/paddle/phi/backends/custom/custom_device.cc: In member function 'virtual void phi::CustomDevice::MemorySet(size_t, void*, uint8_t, size_t)':
./Paddle/paddle/phi/backends/custom/custom_device.cc:443:52: note: returned from 'void* operator new [](std::size_t)'
  443 |       std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
      |                                                    ^
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = unsigned char]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = unsigned char; _Dp = std::default_delete<unsigned char>]' at /usr/include/c++/12.1.0/bits/unique_ptr.h:396:17,
    inlined from 'virtual void phi::CustomDevice::MemorySet(size_t, void*, uint8_t, size_t)' at ./Paddle/paddle/phi/backends/custom/custom_device.cc:446:5:
/usr/include/c++/12.1.0/bits/unique_ptr.h:95:9: error: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
./Paddle/paddle/phi/backends/custom/custom_device.cc: In member function 'virtual void phi::CustomDevice::MemorySet(size_t, void*, uint8_t, size_t)':
./Paddle/paddle/phi/backends/custom/custom_device.cc:443:52: note: returned from 'void* operator new [](std::size_t)'
  443 |       std::unique_ptr<uint8_t> tmp(new uint8_t[size]);
      |                                                    ^
cc1plus: all warnings being treated as errors
make[2]: *** [paddle/phi/backends/custom/CMakeFiles/custom_device.dir/build.make:76: paddle/phi/backends/custom/CMakeFiles/custom_device.dir/custom_device.cc.o] Error 1

其他补充信息 Additional Supplementary Information

check out git master;

cmake
make

The correct fix for this problem is shown below.

diff --git a/paddle/phi/backends/custom/custom_device.cc b/paddle/phi/backends/custom/custom_device.cc
index 928101b09f..d7397353ef 100644
--- a/paddle/phi/backends/custom/custom_device.cc
+++ b/paddle/phi/backends/custom/custom_device.cc
@@ -358,8 +358,7 @@ class CustomDevice : public DeviceInterface {
       }
     } else {
       if (!pimpl_->memory_copy_p2p) {
-        std::unique_ptr<uint8_t> tmp(
-            reinterpret_cast<uint8_t*>(new uint8_t[size]));
+        std::unique_ptr<uint8_t[]> tmp(new uint8_t[size]);
         MemoryCopyD2H(src_dev_id, tmp.get(), src, size);
         MemoryCopyH2D(dst_dev_id, dst, tmp.get(), size);
       } else {
@@ -451,8 +450,7 @@ class CustomDevice : public DeviceInterface {
       PADDLE_ENFORCE_CUSTOM_DEVICE_SUCCESS(
           pimpl_->device_memory_set(device, ptr, value, size));
     } else {
-      std::unique_ptr<uint8_t> tmp(
-          reinterpret_cast<uint8_t*>(new uint8_t[size]));
+      std::unique_ptr<uint8_t[]> tmp(new uint8_t[size]);
       memset(tmp.get(), value, size);
       MemoryCopyH2D(dev_id, ptr, tmp.get(), size);
     }

reference: https://en.cppreference.com/w/cpp/memory/unique_ptr

template <class T,class Deleter> class unique_ptr<T[], Deleter>; Manages a dynamically-allocated array of objects (e.g. allocated with new[])

template<class T, class Deleter = std::default_delete<T> > class unique_ptr; Manages a single object (e.g. allocated with new)

RexSi · 2022-12-29T16:51:18Z

Here is the patch to fix this issue:

From e98f569707ba9fc7669000f593fd51094594c992 Mon Sep 17 00:00:00 2001
From: Si Jinyuan <sijinyuan@foxmail.com>
Date: Fri, 30 Dec 2022 01:42:59 +0900
Subject: [PATCH] Fix GCC12: mismatched-new-delete error in custom_device.cc

according to https://en.cppreference.com/w/cpp/memory/unique_ptr

When using std::unique_ptr to manage array pointers,
should use

template <class T,class Deleter> class unique_ptr<T[], Deleter>;

instead of

template<class T, class Deleter = std::default_delete<T> >
class unique_ptr;
---
 paddle/phi/backends/custom/custom_device.cc | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/paddle/phi/backends/custom/custom_device.cc b/paddle/phi/backends/custom/custom_device.cc
index 928101b09f..d7397353ef 100644
--- a/paddle/phi/backends/custom/custom_device.cc
+++ b/paddle/phi/backends/custom/custom_device.cc
@@ -358,8 +358,7 @@ class CustomDevice : public DeviceInterface {
       }
     } else {
       if (!pimpl_->memory_copy_p2p) {
-        std::unique_ptr<uint8_t> tmp(
-            reinterpret_cast<uint8_t*>(new uint8_t[size]));
+        std::unique_ptr<uint8_t[]> tmp(new uint8_t[size]);
         MemoryCopyD2H(src_dev_id, tmp.get(), src, size);
         MemoryCopyH2D(dst_dev_id, dst, tmp.get(), size);
       } else {
@@ -451,8 +450,7 @@ class CustomDevice : public DeviceInterface {
       PADDLE_ENFORCE_CUSTOM_DEVICE_SUCCESS(
           pimpl_->device_memory_set(device, ptr, value, size));
     } else {
-      std::unique_ptr<uint8_t> tmp(
-          reinterpret_cast<uint8_t*>(new uint8_t[size]));
+      std::unique_ptr<uint8_t[]> tmp(new uint8_t[size]);
       memset(tmp.get(), value, size);
       MemoryCopyH2D(dev_id, ptr, tmp.get(), size);
     }
-- 
2.37.1 (Apple Git-137.1)

luotao1 · 2023-01-13T07:05:31Z

@RexSi Thanks for your fix patch, you can create a PR to fix this issue.

luotao1 · 2023-02-06T02:33:37Z

close due to #47466 merged

bulvara added status/new-issue 新建 type/bug-report 报bug labels May 20, 2022

paddle-bot-old bot assigned LiuChiachi May 20, 2022

LiuChiachi assigned nepeplwu and ronny1996 and unassigned nepeplwu May 23, 2022

Ligoml added status/following-up 跟进中 type/build 编译/安装问题 and removed status/new-issue 新建 type/bug-report 报bug labels May 23, 2022

luotao1 added the good first issue label Jan 13, 2023

luotao1 self-assigned this Jan 13, 2023

luotao1 mentioned this issue Feb 6, 2023

GCC12: mismatched-new-delete error in custom_device.cc #47466

Merged

luotao1 closed this as completed Feb 6, 2023

paddle-bot bot added status/close 已关闭 and removed status/following-up 跟进中 labels Feb 6, 2023

dargueta mentioned this issue Sep 20, 2023

Compilation fails on GCC 12 dargueta/unicorn-lua#40

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GCC12: mismatched-new-delete error in custom_device.cc #42908

GCC12: mismatched-new-delete error in custom_device.cc #42908

bulvara commented May 20, 2022

paddle-bot-old bot commented May 20, 2022

ronny1996 commented May 23, 2022 •

edited

Loading

RexSi commented Dec 29, 2022

bug描述 Describe the Bug

其他补充信息 Additional Supplementary Information

RexSi commented Dec 29, 2022

luotao1 commented Jan 13, 2023

luotao1 commented Feb 6, 2023

GCC12: mismatched-new-delete error in custom_device.cc #42908

GCC12: mismatched-new-delete error in custom_device.cc #42908

Comments

bulvara commented May 20, 2022

bug描述 Describe the Bug

其他补充信息 Additional Supplementary Information

paddle-bot-old bot commented May 20, 2022

ronny1996 commented May 23, 2022 • edited Loading

RexSi commented Dec 29, 2022

bug描述 Describe the Bug

其他补充信息 Additional Supplementary Information

The correct fix for this problem is shown below.

RexSi commented Dec 29, 2022

luotao1 commented Jan 13, 2023

luotao1 commented Feb 6, 2023

ronny1996 commented May 23, 2022 •

edited

Loading