From 39b3a08005117f87a454e60ae435b1f787f42f05 Mon Sep 17 00:00:00 2001
From: Clara Ni <clara.ni@outlook.fr>
Date: Tue, 24 Dec 2024 16:20:55 +0100
Subject: [PATCH] front: drop ViaStopDurationSelector

Not used anymore since the end of TS V2 migration and the new STDCM view page

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
---
 .../ViaStopDurationSelector.tsx               | 75 -------------------
 .../Itinerary/DisplayItinerary/Vias.tsx       | 15 +---
 .../components/Itinerary/Itinerary.tsx        | 11 +--
 .../osrdConfCommon/__tests__/utils.ts         | 20 -----
 .../reducers/osrdconf/osrdConfCommon/index.ts | 23 +-----
 5 files changed, 4 insertions(+), 140 deletions(-)
 delete mode 100644 front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/ViaStopDurationSelector.tsx

diff --git a/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/ViaStopDurationSelector.tsx b/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/ViaStopDurationSelector.tsx
deleted file mode 100644
index 17917ac1703..00000000000
--- a/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/ViaStopDurationSelector.tsx
+++ /dev/null
@@ -1,75 +0,0 @@
-import { useEffect, useState } from 'react';
-
-import InputSNCF from 'common/BootstrapSNCF/InputSNCF';
-import { useOsrdConfActions } from 'common/osrdContext';
-import type { PathStep } from 'reducers/osrdconf/types';
-import { useAppDispatch } from 'store';
-import { useDebounce } from 'utils/helpers';
-import { ISO8601Duration2sec, formatDurationAsISO8601 } from 'utils/timeManipulation';
-
-const ViaStopDurationSelector = ({
-  via,
-  focusedViaId,
-  setFocusedViaId,
-}: {
-  via: PathStep;
-  focusedViaId?: string;
-  setFocusedViaId: (focusedViaIndex?: string) => void;
-}) => {
-  const dispatch = useAppDispatch();
-  const { updateViaStopTime } = useOsrdConfActions();
-
-  const currentStopTime = via.stopFor ? ISO8601Duration2sec(via.stopFor) : 0;
-
-  const [stopTime, setStopTime] = useState(currentStopTime);
-  const debouncedStopTime = useDebounce(stopTime, 2000);
-
-  const updateViaStopDuration = (durationInSec: number) => {
-    dispatch(updateViaStopTime({ via, duration: formatDurationAsISO8601(durationInSec) }));
-  };
-
-  useEffect(() => {
-    if (debouncedStopTime !== currentStopTime) {
-      updateViaStopDuration(debouncedStopTime);
-      setFocusedViaId(undefined);
-    }
-  }, [debouncedStopTime]);
-
-  return (
-    <>
-      {via.id !== focusedViaId && (
-        <div className="default-durations-button mr-1">
-          <button type="button" className="mr-1 px-1" onClick={() => updateViaStopDuration(30)}>
-            30s
-          </button>
-          <button type="button" className="mr-1 px-1" onClick={() => updateViaStopDuration(60)}>
-            1min
-          </button>
-          <button type="button" className="mr-1 px-1" onClick={() => updateViaStopDuration(120)}>
-            2min
-          </button>
-        </div>
-      )}
-      <div role="button" tabIndex={-1} onClick={() => setFocusedViaId(via.id)}>
-        {via.id === focusedViaId ? (
-          <InputSNCF
-            type="number"
-            id={`osrd-config-stoptime-via-${via.id}`}
-            onChange={(e) => setStopTime(Number(e.target.value))}
-            value={stopTime}
-            unit="s"
-            focus
-            selectAllOnFocus
-            sm
-            noMargin
-            textRight
-          />
-        ) : (
-          <div className="stoptime">{`${currentStopTime}s`}</div>
-        )}
-      </div>
-    </>
-  );
-};
-
-export default ViaStopDurationSelector;
diff --git a/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/Vias.tsx b/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/Vias.tsx
index 8f4864849ca..1eeea37e191 100644
--- a/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/Vias.tsx
+++ b/front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/Vias.tsx
@@ -1,5 +1,3 @@
-import { useState } from 'react';
-
 import { XCircle } from '@osrd-project/ui-icons';
 import cx from 'classnames';
 import type { Position } from 'geojson';
@@ -13,20 +11,16 @@ import { isPathStepInvalid } from 'modules/pathfinding/utils';
 import { moveElement, removeElementAtIndex } from 'utils/array';
 import { formatUicToCi } from 'utils/strings';
 
-import ViaStopDurationSelector from './ViaStopDurationSelector';
-
 type ViasProps = {
-  shouldManageStopDuration?: boolean;
   zoomToFeaturePoint: (lngLat?: Position, id?: string) => void;
 };
 
-const Vias = ({ zoomToFeaturePoint, shouldManageStopDuration }: ViasProps) => {
+const Vias = ({ zoomToFeaturePoint }: ViasProps) => {
   const { t } = useTranslation('operationalStudies/manageTrainSchedule');
   const { getVias, getPathSteps } = useOsrdConfSelectors();
   const vias = useSelector(getVias());
   const pathSteps = useSelector(getPathSteps);
   const { launchPathfinding } = useManageTrainScheduleContext();
-  const [focusedViaId, setFocusedViaId] = useState<string>();
 
   return (
     <DragDropContext
@@ -80,13 +74,6 @@ const Vias = ({ zoomToFeaturePoint, shouldManageStopDuration }: ViasProps) => {
                           </small>
                         )}
                       </div>
-                      {shouldManageStopDuration && (
-                        <ViaStopDurationSelector
-                          via={via}
-                          focusedViaId={focusedViaId}
-                          setFocusedViaId={setFocusedViaId}
-                        />
-                      )}
                       <button
                         data-testid="delete-via-button"
                         className="btn btn-sm btn-only-icon btn-white ml-auto"
diff --git a/front/src/modules/pathfinding/components/Itinerary/Itinerary.tsx b/front/src/modules/pathfinding/components/Itinerary/Itinerary.tsx
index fe1198f24e8..32e523a0c91 100644
--- a/front/src/modules/pathfinding/components/Itinerary/Itinerary.tsx
+++ b/front/src/modules/pathfinding/components/Itinerary/Itinerary.tsx
@@ -25,11 +25,7 @@ import Origin from './DisplayItinerary/Origin';
 import Vias from './DisplayItinerary/Vias';
 import ModalSuggestedVias from './ModalSuggestedVias';
 
-type ItineraryProps = {
-  shouldManageStopDuration?: boolean;
-};
-
-const Itinerary = ({ shouldManageStopDuration }: ItineraryProps) => {
+const Itinerary = () => {
   const { getPathSteps, getOrigin, getDestination, getPowerRestriction } = useOsrdConfSelectors();
   const origin = useSelector(getOrigin);
   const destination = useSelector(getDestination);
@@ -168,10 +164,7 @@ const Itinerary = ({ shouldManageStopDuration }: ItineraryProps) => {
           <Origin zoomToFeaturePoint={zoomToFeaturePoint} />
           <div className="vias-list mb-2" data-testid="itinerary-vias">
             {pathSteps.length > 2 ? (
-              <Vias
-                zoomToFeaturePoint={zoomToFeaturePoint}
-                shouldManageStopDuration={shouldManageStopDuration}
-              />
+              <Vias zoomToFeaturePoint={zoomToFeaturePoint} />
             ) : (
               <small data-testid="no-waypoint-chosen-text" className="ml-4">
                 {t('noPlaceChosen')}
diff --git a/front/src/reducers/osrdconf/osrdConfCommon/__tests__/utils.ts b/front/src/reducers/osrdconf/osrdConfCommon/__tests__/utils.ts
index afcac946f94..9fd609ad5aa 100644
--- a/front/src/reducers/osrdconf/osrdConfCommon/__tests__/utils.ts
+++ b/front/src/reducers/osrdconf/osrdConfCommon/__tests__/utils.ts
@@ -1,6 +1,5 @@
 import { describe, beforeEach, it, expect } from 'vitest';
 
-import { StdcmStopTypes } from 'applications/stdcm/types';
 import type { Distribution, Infra, TrainScheduleBase } from 'common/api/osrdEditoastApi';
 import type { OperationalStudiesConfSlice } from 'reducers/osrdconf/operationalStudiesConf';
 import { defaultCommonConf } from 'reducers/osrdconf/osrdConfCommon';
@@ -187,25 +186,6 @@ const testCommonConfReducers = (slice: OperationalStudiesConfSlice | StdcmConfSl
     expect(state.initialSpeed).toBe(newInitialSpeed);
   });
 
-  it('should handle updateViaStopTime', () => {
-    const pathSteps = testDataBuilder.buildPathSteps();
-    const via = pathSteps[1];
-    const store = createStore(slice, {
-      pathSteps,
-    });
-
-    store.dispatch(
-      slice.actions.updateViaStopTime({
-        via,
-        duration: 'PT60S',
-        stopType: StdcmStopTypes.SERVICE_STOP,
-      })
-    );
-    const state = store.getState()[slice.name];
-    expect(state.pathSteps[1]?.stopFor).toEqual('PT60S');
-    expect(state.pathSteps[1]?.stopType).toEqual('serviceStop');
-  });
-
   it('should handle updateGridMarginBefore', () => {
     const newGridMarginBefore = 5;
     defaultStore.dispatch(slice.actions.updateGridMarginBefore(newGridMarginBefore));
diff --git a/front/src/reducers/osrdconf/osrdConfCommon/index.ts b/front/src/reducers/osrdconf/osrdConfCommon/index.ts
index 9fb4b27a188..36076c68d31 100644
--- a/front/src/reducers/osrdconf/osrdConfCommon/index.ts
+++ b/front/src/reducers/osrdconf/osrdConfCommon/index.ts
@@ -1,7 +1,6 @@
 import type { CaseReducer, PayloadAction } from '@reduxjs/toolkit';
 import type { Draft } from 'immer';
 
-import { type StdcmStopTypes } from 'applications/stdcm/types';
 import { type InfraStateReducers, buildInfraStateReducers, infraState } from 'reducers/infra';
 import type {
   OperationalStudiesConfSlice,
@@ -10,7 +9,7 @@ import type {
 import type { OperationalStudiesConfSelectors } from 'reducers/osrdconf/operationalStudiesConf/selectors';
 import type { StdcmConfSlice, StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
 import type { StdcmConfSelectors } from 'reducers/osrdconf/stdcmConf/selectors';
-import type { OsrdConfState, PathStep } from 'reducers/osrdconf/types';
+import type { OsrdConfState } from 'reducers/osrdconf/types';
 
 export const defaultCommonConf: OsrdConfState = {
   constraintDistribution: 'MARECO',
@@ -54,10 +53,6 @@ interface CommonConfReducers<S extends OsrdConfState> extends InfraStateReducers
   ['updateRollingStockID']: CaseReducer<S, PayloadAction<S['rollingStockID']>>;
   ['updateSpeedLimitByTag']: CaseReducer<S, PayloadAction<S['speedLimitByTag'] | null>>;
   ['updateInitialSpeed']: CaseReducer<S, PayloadAction<S['initialSpeed']>>;
-  ['updateViaStopTime']: CaseReducer<
-    S,
-    PayloadAction<{ via: PathStep; duration: string; stopType?: StdcmStopTypes }>
-  >;
   ['updateGridMarginBefore']: CaseReducer<S, PayloadAction<S['gridMarginBefore']>>;
   ['updateGridMarginAfter']: CaseReducer<S, PayloadAction<S['gridMarginAfter']>>;
   ['updatePathSteps']: CaseReducer<S, PayloadAction<S['pathSteps']>>;
@@ -121,22 +116,6 @@ export function buildCommonConfReducers<S extends OsrdConfState>(): CommonConfRe
     updateInitialSpeed(state: Draft<S>, action: PayloadAction<S['initialSpeed']>) {
       state.initialSpeed = action.payload;
     },
-    // TODO: Change the type of duration to number. It is preferable to keep this value in seconds in the store
-    //* to avoid multiple conversions between seconds and ISO8601 format across the front.
-    updateViaStopTime(
-      state: Draft<S>,
-      action: PayloadAction<{ via: PathStep; duration: string; stopType?: StdcmStopTypes }>
-    ) {
-      const {
-        payload: { via, duration, stopType },
-      } = action;
-      state.pathSteps = state.pathSteps.map((pathStep) => {
-        if (pathStep && pathStep.id === via.id) {
-          return { ...pathStep, stopFor: duration, stopType };
-        }
-        return pathStep;
-      });
-    },
     updateGridMarginBefore(state: Draft<S>, action: PayloadAction<S['gridMarginBefore']>) {
       state.gridMarginBefore = action.payload;
     },