Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lazy in storage items #78

Closed
HCastano opened this issue Feb 11, 2022 · 2 comments · Fixed by #79
Closed

Remove Lazy in storage items #78

HCastano opened this issue Feb 11, 2022 · 2 comments · Fixed by #79

Comments

@HCastano
Copy link

Hey there, cool project!

This is more of an FYI in case you're not following the ink! repo, but with the next release we're getting rid of ink_storage::lazy::Lazy, which I see you're using in your storage contract.

I'd also be curious to know if you notice any performance issues due to it.

@tash-2s
Copy link
Member

tash-2s commented Feb 11, 2022

Hi, thank you for letting me know!

I'm aware of the removal of some storage data structures, so I'll update our code later. Also, I'm looking forward to revamping our contracts with the set_code_hash integration.

@HCastano
Copy link
Author

Also, I'm looking forward to revamping our contracts with the set_code_hash integration

Yep! Should definitely clean things up a bit

tash-2s added a commit to tash-2s/open-emoji-battler that referenced this issue Feb 13, 2022
This commit has two changes.
1. Remove `Lazy` usages: close OpenEmojiBattler#78
2. Use `Option` to clarify unset values
We should be able to clearly differentiate whether none or empty data for these items.
@tash-2s tash-2s linked a pull request Feb 13, 2022 that will close this issue
forbesus added a commit to forbesus/OpenEmojiBattler that referenced this issue Feb 18, 2024
This commit has two changes.
1. Remove `Lazy` usages: close OpenEmojiBattler/open-emoji-battler#78
2. Use `Option` to clarify unset values
We should be able to clearly differentiate whether none or empty data for these items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants