Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PROJ4 CMake name #3168

Open
mwtoews opened this issue Apr 19, 2022 · 3 comments
Open

Remove PROJ4 CMake name #3168

mwtoews opened this issue Apr 19, 2022 · 3 comments
Labels
task
Milestone
10.0.0

Comments

@mwtoews
Copy link
Member

mwtoews commented Apr 19, 2022

PROJ 7.0 changed the CMake project name from PROJ4 to PROJ (#1885, #1910).

PROJ 9.1 made find_package(PROJ4) show a deprecation warning (#3094, #3165).

PROJ 10.0 should finally remove this support.
@mwtoews mwtoews added the task label Apr 19, 2022
@mwtoews mwtoews added this to the 10.0.0 milestone Apr 19, 2022
@rouault rouault mentioned this issue Apr 23, 2022
Closed
@rouault
Copy link
Member

rouault commented Sep 14, 2022

to solve OSGeo/gdal#5646, maybe we should offer a CMake variable to opt to disable exporting PROJ4, as something doable in PROJ 9.x series ?

@mwtoews
Copy link
Member Author

mwtoews commented Sep 14, 2022

Fine with me to bump this earlier in the 9.x series, but I also like to look further at the GDAL issue.

rouault added a commit to rouault/PROJ that referenced this issue Sep 14, 2022
@rouault
CMake: add a INSTALL_LEGACY_CMAKE_FILES option (fixes OSGeo/gdal#5646)
3b18cd7 
to control whether the PROJ4 legacy target should be exported (refs OSGeo#3168)

The default is ON, unless PROJ is built as part of a CMake subproject.
@rouault rouault mentioned this issue Sep 14, 2022
Merged
@dg0yt
Copy link
Contributor

dg0yt commented Sep 15, 2022 

... target "proj" that is not in this export set, but in multiple other export sets: lib/cmake/proj/proj-targets.cmake, lib/cmake/proj/proj4-targets.cmake, lib/cmake/proj4/proj-targets.cmake, lib/cmake/proj4/proj4-targets.cmake

Instead of creating multiple exports of proj, it should be exported only once under the canonical name, and every alternative name should have been created as an interface library which depends on the canonical name.

rouault added a commit to rouault/PROJ that referenced this issue Sep 15, 2022
@rouault
CMake: add a INSTALL_LEGACY_CMAKE_FILES option (fixes OSGeo/gdal#5646)
ad660a8 
to control whether the PROJ4 legacy target should be exported (refs OSGeo#3168)

The default is ON, unless PROJ is built as part of a CMake subproject.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
3 participants
@mwtoews @rouault @dg0yt