From 8b96509f58656cd61bd393f5201fd25f0ff748b2 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Thu, 23 May 2024 09:35:17 -0700 Subject: [PATCH] Deprecate the AWS ECS detector (#5638) Towards #5543 --- CHANGELOG.md | 3 +++ detectors/aws/ecs/ecs.go | 9 +++++++++ detectors/aws/ecs/go.mod | 1 + detectors/aws/ecs/test/ecs_test.go | 2 +- 4 files changed, 14 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d660719cc80..25ee8862e6b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,8 +14,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm If you would like to become a Code Owner of this module and prevent it from being removed, see [#5551]. (#5598) - The `go.opentelemetry.io/contrib/detectors/aws/ec2` package is deprecated. If you would like to become a Code Owner of this module and prevent it from being removed, see [#5542]. (#5636) +- The `go.opentelemetry.io/contrib/detectors/aws/ecs` package is deprecated. + If you would like to become a Code Owner of this module and prevent it from being removed, see [#5543]. (#5637) [#5542]: /~https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5542 +[#5543]: /~https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5543 [#5551]: /~https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5551 ## [1.27.0/0.52.0/0.21.0/0.7.0/0.2.0] - 2024-05-21 diff --git a/detectors/aws/ecs/ecs.go b/detectors/aws/ecs/ecs.go index fe5c3423834..1da3125a064 100644 --- a/detectors/aws/ecs/ecs.go +++ b/detectors/aws/ecs/ecs.go @@ -1,6 +1,15 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 +// Package ecs provide an OpenTelemetry resource detector for AWS ECS +// instances. +// +// Deprecated: ecs has no Code Owner. +// After August 21, 2024, it may no longer be supported and may stop +// receiving new releases unless a new Code Owner is found. See +// [this issue] if you would like to become the Code Owner of this module. +// +// [this issue]: /~https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5543 package ecs // import "go.opentelemetry.io/contrib/detectors/aws/ecs" import ( diff --git a/detectors/aws/ecs/go.mod b/detectors/aws/ecs/go.mod index d5b13ea9017..f31d52c3587 100644 --- a/detectors/aws/ecs/go.mod +++ b/detectors/aws/ecs/go.mod @@ -1,3 +1,4 @@ +// Deprecated: ecs has no Code Owner. module go.opentelemetry.io/contrib/detectors/aws/ecs go 1.21 diff --git a/detectors/aws/ecs/test/ecs_test.go b/detectors/aws/ecs/test/ecs_test.go index a34b2da5ecd..52543963bcf 100644 --- a/detectors/aws/ecs/test/ecs_test.go +++ b/detectors/aws/ecs/test/ecs_test.go @@ -11,7 +11,7 @@ import ( "strings" "testing" - ecs "go.opentelemetry.io/contrib/detectors/aws/ecs" + ecs "go.opentelemetry.io/contrib/detectors/aws/ecs" // nolint:staticcheck // deprecated. "go.opentelemetry.io/otel/attribute" "go.opentelemetry.io/otel/sdk/resource" semconv "go.opentelemetry.io/otel/semconv/v1.25.0"