Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed useless click #30615

Merged
merged 5 commits into from
Feb 27, 2025
Merged

feat: removed useless click #30615

merged 5 commits into from
Feb 27, 2025

Conversation

javiergarciavera
Copy link
Contributor

@javiergarciavera javiergarciavera commented Feb 27, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@javiergarciavera javiergarciavera added the team-qa QA team label Feb 27, 2025
@javiergarciavera javiergarciavera self-assigned this Feb 27, 2025
@javiergarciavera javiergarciavera requested a review from a team as a code owner February 27, 2025 19:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@javiergarciavera javiergarciavera requested a review from a team as a code owner February 27, 2025 20:14
@javiergarciavera javiergarciavera added this pull request to the merge queue Feb 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [8a3f1f9]
Page Load Metrics (1788 ± 115 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22924251593590283
domContentLoaded150023821763227109
load150424431788239115
domInteractive269238178
backgroundConnect883302010
firstReactRender1578302110
getState56812136
initialActions00000
loadScripts10641777130218689
setupStore765212010
uiStartup172027232039262126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 2228a13 Feb 27, 2025
79 checks passed
@javiergarciavera javiergarciavera deleted the QA-XXX-fixFlakiness branch February 27, 2025 22:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants