-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add error boundary on NFT grid items #30486
Open
Prithpal-Sooriya
wants to merge
6
commits into
main
Choose a base branch
from
fix/nft-grid-item-crash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+161
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
5dd68c6
to
b1912d6
Compare
b1bf6c7
to
12324bf
Compare
Builds ready [12324bf]
Page Load Metrics (1673 ± 50 ms)
Bundle size diffs
|
gambinish
reviewed
Feb 27, 2025
type ErrorBoundaryProps = { children: ReactNode; fallback: () => ReactNode }; | ||
type ErrorBoundaryState = { hasError: boolean }; | ||
|
||
class NFTGridItemErrorBoundary extends Component< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad that error boundaries like this need to be class components, seems like a framework limitation of React.
gambinish
approved these changes
Feb 27, 2025
Builds ready [96f149a]
Page Load Metrics (1567 ± 57 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows us to capture errors when rendering grid items and prevent them from bubbling up and crashing the app.
Ideally we want to handle the actual causes for the crash. In this case it was an NFT that has 2 images, when we expect a single image string.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist