Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test covering SPL tokens and transaction list #30471

Merged
merged 31 commits into from
Feb 27, 2025

Conversation

javiergarciavera
Copy link
Contributor

@javiergarciavera javiergarciavera commented Feb 20, 2025

Description

Added in this PR:

  • solana-snap-wallet version upgraded to 1.7
  • test covering send SPL tokens scenarios
  • test covering transaction list
  • some changes on common Solana funcions

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@javiergarciavera javiergarciavera requested review from a team as code owners February 20, 2025 16:50
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Feb 20, 2025
Copy link

socket-security bot commented Feb 20, 2025

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@metamaskbot
Copy link
Collaborator

Builds ready [a6dcd94]
Page Load Metrics (1693 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27422901608375180
domContentLoaded138622631664220106
load143722761693217104
domInteractive23205463919
backgroundConnect889282512
firstReactRender1474322311
getState45519189
initialActions01000
loadScripts9181666119918690
setupStore76915178
uiStartup157525261925242116
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this error when executing locally and the CI has passed with no issues. Could you please check at your end.

Screenshot 2025-02-20 at 2 34 00 PM

@metamaskbot
Copy link
Collaborator

Builds ready [4b32c31]
Page Load Metrics (1609 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33218201523292140
domContentLoaded13781869157912460
load14481884160911655
domInteractive23186483617
backgroundConnect1087382211
firstReactRender1578302411
getState564172010
initialActions01000
loadScripts9971425116610651
setupStore775252512
uiStartup16392127184713263
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5d3a9bf]
Page Load Metrics (1807 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26220951729361173
domContentLoaded15402073176612962
load15802094180713163
domInteractive25177504120
backgroundConnect1488442311
firstReactRender158125168
getState567242110
initialActions00000
loadScripts1108150713089646
setupStore75517147
uiStartup18262395207415072
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@javiergarciavera
Copy link
Contributor Author

I noticed this error when executing locally and the CI has passed with no issues. Could you please check at your end.

Screenshot 2025-02-20 at 2 34 00 PM

so you need to update the privacy-snapshot, if you check the PR, there are new urls added to the snapshot in order to skip that failure

@metamaskbot
Copy link
Collaborator

Builds ready [62df2c0]
Page Load Metrics (1670 ± 106 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26823121539472227
domContentLoaded136322871645224108
load142723041670221106
domInteractive239640189
backgroundConnect1179322210
firstReactRender1483312512
getState471222110
initialActions01000
loadScripts10011692121817886
setupStore74813115
uiStartup162526231901250120
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

zone-live
zone-live previously approved these changes Feb 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [00f0583]
Page Load Metrics (1569 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14191937156912058
domContentLoaded13801906154312057
load14191941156912158
domInteractive236732136
backgroundConnect124926115
firstReactRender1469352412
getState54713126
initialActions01000
loadScripts9901462113810551
setupStore7441195
uiStartup16072176177813464
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@javiergarciavera javiergarciavera added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit b770118 Feb 27, 2025
79 checks passed
@javiergarciavera javiergarciavera deleted the QA-112-e2e-tests-activity-list branch February 27, 2025 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants