Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ArrayMap::insert return an error or panic? #4

Open
Luro02 opened this issue Jul 3, 2021 · 0 comments
Open

Should ArrayMap::insert return an error or panic? #4

Luro02 opened this issue Jul 3, 2021 · 0 comments
Labels
A-Design Some design decision has to be made

Comments

@Luro02
Copy link
Owner

Luro02 commented Jul 3, 2021

Depends on how likely it is that one runs out of capacity? I think it would be good to provide both a panicking and non-panicking method.

The problem is that try_insert seems to be used differently in std/hashbrown, so a different name is needed.
@Luro02 Luro02 added the A-Design Some design decision has to be made label Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Design Some design decision has to be made
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Luro02