Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot and Kusama nominator controller accounts are being deprecated #1350

Closed
rossbulat opened this issue May 12, 2023 · 4 comments · Fixed by #1603
Closed

Polkadot and Kusama nominator controller accounts are being deprecated #1350

rossbulat opened this issue May 12, 2023 · 4 comments · Fixed by #1603
Assignees

Comments

@rossbulat
Copy link

Polkadot and Kusama nominator controller accounts are being deprecated

This is an issue to notify the maintainers of this repo that nominator controller accounts are being deprecated on Polkadot and Kusama, in favour of proxy accounts. In an upcoming runtime upgrade (version and date is yet to be determined), 2 call signatures of the staking pallet will change. These are breaking changes for UIs, so UIs will need to update their codebases when the changes come into effect.

Call Changes

The staking.bond and staking.setController call signatures have now changed in the Substrate codebase PR here, and will take effect in a future runtime upgrade.

  • set_controller(controller) will become set_controller(). This call will simply set the controller account to the caller's stash account, if it is not already.
  • bond(controller, value, payee) will become bond(value, payee). This call will now set the caller as the controller account (same as the stash).

UIs can prepare now by adding a controller deprecation message, and allow stakers to change their controller accounts back to their stash using the existing staking.setController(controller) call. The Polkadot staking dashboard recently deployed this functionality and may be useful as reference code.

Next Steps

  • A follow-up message will be made when we know when these changes will be on Westend, giving UIs time to test any needed changes.
  • Follow-up messages will be made here when we know the runtime version and date of the change on Polkadot and Kusama.

Other Resources

@rossbulat
Copy link
Author

8th June 2023 Update

Westend now reflects the changes of bond and set_controller.

  • set_controller(controller) has become set_controller(). This call simply sets the controller account to the caller’s stash account, if it is not already.
  • bond(controller, value, payee) has become bond(value, payee). This call now sets the caller as the controller account (same as the stash).

UIs can now test any necessary changes on Westend leading up to the mainnet releases.

We can assume that the next Polkadot and Kusama releases will reflect these changes, and that it will be at least 4-6 weeks before they are deployed on the networks.

@rossbulat
Copy link
Author

Mainnet Deployment Timeline Confirmed

The corresponding referendum Ref 221 was submitted in Kusama and it is scheduled to be enacted on the 03/07/2023 (block #18625000).

Ref 18 was submitted in Polkadot and it is scheduled to be enacted on the 18/07/2023 (block #16450000).

@saltict
Copy link

saltict commented Jun 26, 2023

Mainnet Deployment Timeline Confirmed

The corresponding referendum Ref 221 was submitted in Kusama and it is scheduled to be enacted on the 03/07/2023 (block #18625000).

Ref 18 was submitted in Polkadot and it is scheduled to be enacted on the 18/07/2023 (block #16450000).

Hi @rossbulat,

Many thanks for your notice, we are working on this update and will roll out the necessary changes soon.

Have a good day.

@saltict saltict added this to the Milestone 6 milestone Jun 26, 2023
@rossbulat
Copy link
Author

Awesome, looking forward to see the updates live :)

@nampc1 nampc1 modified the milestones: Milestone 6, Milestone 7 Jul 5, 2023
@nampc1 nampc1 linked a pull request Jul 5, 2023 that will close this issue
@hieudd hieudd modified the milestones: Milestone 7, Milestone 6 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants