Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing precision option for values with default precision 0 #8815

Open
ghoz opened this issue Feb 16, 2025 · 0 comments
Open

missing precision option for values with default precision 0 #8815

ghoz opened this issue Feb 16, 2025 · 0 comments

Comments

@ghoz
Copy link
Contributor

ghoz commented Feb 16, 2025

Following up on #8792

It looks like we are skipping precision if the default precision is 0 which is the case for ac_frequency

if (utils.calibrateAndPrecisionRoundOptionsDefaultPrecision[expose.name] !== 0) {
definition.options.push(exposesLib.options.precision(expose.name));
}

short term thinking :
change the default ac_frequency precision to 2 as it makes more sense (grid opreators are supposed to keep the frequency very tightly around the standard value).

propper fixing : move to -1 for no precision rather than 0? as this most likely impacts others valuesbwith default prexision of 0 ...
does a -1 precision makes sense (rounding to 10s ?)

@ghoz ghoz changed the title missing ac_frequency_precision missing precision option for values with default precision 0 Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant