Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Option to Use Min-Range or Chebyshev linearization modes #33

Open
mewilhel opened this issue Mar 30, 2021 · 3 comments

Comments

@mewilhel
Copy link

It looks like the main linearization mode supported is min-range. It would be nice to support choosing between Chebyshev (minimize the maximum error) and Min-Range.

@dpsanders
Copy link
Member

Agreed! Please feel free to implement that.

@mewilhel
Copy link
Author

I'll take a swing at this.

From an overall structure standpoint, does associating a linearization mode parameter to Aff structure (such as below) seem like a good starting point? Then we'd simply dispatching off of this parameter. It would probably present some issues later on if someone wanted to mix linearization modes but it likely accounts for 99% of the use cases.

abstract type AbstractLinearization end
struct MinRange <: AbstractLinearization end
struct Chebyshev <: AbstractLinearization end

struct Aff{N,T<:AbstractFloat,S<:AbstractLinearization} ...

@dpsanders
Copy link
Member

That seems like a good idea, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants