User-defined keyword separator does not apply to Merge Groups

[ryan-carpenter]

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

openSUSE Tumbleweed

Checked with the latest development build (copy version output from About dialog)

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

The user-defined "Keyword separator" applies to keywords and groups in the entry table, but not in the Merge/Find duplicates window. The correct separator is used to merge keywords, but not groups.

1. Set a non-default keyword separator in Preferences > Entry
2. Notice that the keyword separator also applies to the groups field (as intended)
3. Create two entries with at least one group per entry but not identical group sets.
4. Select the two entries and click Quality > Merge Entries
5. In the merge window, Click the icon for Merge Groups
6. Notice that the groups are joined using the default separator (comma) instead of the user-defined character.

The keyword separator is applies to keywords and groups, so I expect the same separator to be used for merging keywords or merging groups.

Appendix

JabRef 100.0.0
Linux 6.12.8-2-default amd64
Java 23.0.1
JavaFX 23.0.2+3
...

Log File

Not applicable

[ryan-carpenter]

The separator is explicitly defined in the group merger.

jabref/src/main/java/org/jabref/gui/mergeentries/newmergedialog/fieldsmerger/GroupMerger.java

Line 14 in 85e9478

public static final String GROUPS_SEPARATOR = ", ";

The keyword merger uses getKeywordSeparator.

jabref/src/main/java/org/jabref/gui/mergeentries/newmergedialog/fieldsmerger/KeywordMerger.java

Line 22 in 85e9478

Character delimiter = bibEntryPreferences.getKeywordSeparator();

[Siedlerchr]

@HoussemNasri Do you remember why the Groups Separator is hard coded?

[HoussemNasri]

Hmmm, probably because this was implemented before we made the separator dynamic.

[patriciagam]

/assign-me

[github-actions]

👋 Hey @patriciagam, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 17 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.