Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening JabRef, Ctrl+W does not behave as expected. #12530

Open
2 tasks done
priyanshu16095 opened this issue Feb 19, 2025 · 4 comments
Open
2 tasks done

When opening JabRef, Ctrl+W does not behave as expected. #12530

priyanshu16095 opened this issue Feb 19, 2025 · 4 comments
Assignees
Labels

Comments

@priyanshu16095
Copy link
Contributor

priyanshu16095 commented Feb 19, 2025

JabRef version

5.15 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

There is a bug in the Ctrl+W shortcut. Instead of closing the current tab, it always closes the first tab in JabRef.

  1. Open JabRef.
  2. Use Ctrl+W key.
  3. It will close the first tab, instead of current tab.
Recording.2025-02-19.mp4
@urlyy
Copy link
Contributor

urlyy commented Feb 22, 2025

On my Ubuntu 24.04, I've observed this effect as well. I've traced it to the CloseDatabaseAction class in the file java/org/jabref/gui/frame/JabRefFrame.java, where the logic for close current library is implemented.

However, when running the program, it seems to only close the libraryTab member variable ( Only execute the code within the green box in the following figure ). However, libraryTab is always the first tab, not the current tab. And after closing, it does not update libraryTab. This results in the next use of Ctrl+W not being able to close the newest first tab, effectively doing nothing.

Image

I have currently only located the position where the error occurs, and I haven't delved into it deeply yet. I haven't understood the significance of libraryTab at the moment.

I think we need to change it to use only tabContainer.getCurrentLibraryTab().

@urlyy
Copy link
Contributor

urlyy commented Feb 22, 2025

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Feb 22, 2025
Copy link
Contributor

👋 Hey @urlyy, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 90 days (by 23 May 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@urlyy
Copy link
Contributor

urlyy commented Mar 3, 2025

I apologize. I would like to unassign myself from this issue.Due to various reasons that have kept me quite busy, I won't be able to continue working on this issue. Just allowing others to contribute and solve this issue as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Normal priority
Development

No branches or pull requests

3 participants