Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract API methods #10

Closed
kkazmierczyk opened this issue Oct 26, 2024 · 0 comments · Fixed by #11
Closed

Extract API methods #10

kkazmierczyk opened this issue Oct 26, 2024 · 0 comments · Fixed by #11
Assignees
@kkazmierczyk
Labels
current sprint (10.12) enhancement New feature or request

Comments

@kkazmierczyk
Copy link
Collaborator

As part of #8 we need an API so that we can run the tool from the code

I would like to have JavacoreAnalyser.parseFiles(filelist, params) which will return JavacoreSet additional method: JavacoreSet.generateReportFiles() the reason is, that sometimes we do not need report files and this method is fast.

The alternative not to implement it, is to run each time the tool as a separate process from web application but it is ugly solution
@kkazmierczyk kkazmierczyk added the enhancement New feature or request label Oct 26, 2024
@kkazmierczyk kkazmierczyk self-assigned this Oct 26, 2024
kkazmierczyk added a commit that referenced this issue Oct 26, 2024
@kkazmierczyk
Ref #10 Refactorisation in javacore_analyzer.py
fac3a3c 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 26, 2024
@kkazmierczyk
Ref #10 Moved started logging to the top
efddcf7 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 26, 2024
@kkazmierczyk
Ref #10 Removed inputDir from API
425acb1 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 26, 2024
@kkazmierczyk
Ref #10 Added creation of directory for logging
2ba8853 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 26, 2024
@kkazmierczyk
Ref #10 Externalise some methods. Add some documentation
b82e5c6 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 26, 2024
@kkazmierczyk
Ref #10 Added API method get_javacore_set_in_xml
fffacfe 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 26, 2024
@kkazmierczyk
Ref #10 Small refactor
19caf96 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>

Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 26, 2024
@kkazmierczyk
Ref #10 Exctract methods
b6dca83 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 26, 2024
@kkazmierczyk
Ref #10 Tests added
1fc56ff 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
@kkazmierczyk kkazmierczyk linked a pull request Oct 26, 2024 that will close this issue
10 extract api methods #11
Merged
@kkazmierczyk kkazmierczyk mentioned this issue Oct 26, 2024
Merged
kkazmierczyk added a commit that referenced this issue Oct 27, 2024
@kkazmierczyk
Ref #10 Removed duplicated code in process_javacores
ac87e7c 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 27, 2024
@kkazmierczyk
Ref #10 Not exiting with API when no Javacores
ef2556d 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
kkazmierczyk added a commit that referenced this issue Oct 30, 2024
@kkazmierczyk
Ref #10 use try/finally for reading in get_javacore_set_in_xml
cfea377 
Signed-off-by: Krzysztof Kaźmierczyk <kazm@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkazmierczyk kkazmierczyk

Labels
current sprint (10.12) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

10 extract api methods IBM/javacore-analyser
1 participant
@kkazmierczyk