Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated method call in customize_machine server profile is causing issues with network configuration #57

Open
tmiotto opened this issue May 17, 2017 · 4 comments

Comments

@tmiotto
Copy link
Contributor

tmiotto commented May 17, 2017

Description

customize_machine.rb is using ServerProfile#available_networks that won't work with the SDK code.

Need to check if this was someday compatible with the OneView SDK, or if it came from legacy code.

A fix is necessary, or by changing it to ServerProfile#get_available_networks or by binding the oneview-sdk gem to a previous version.

Environment

oneview-sdk gem version: 2.0.0 onwards
chef-provisioning-oneview version: 1.3.0

Root Cause

See line 45 of customize_machine.rb

@tmiotto
Copy link
Contributor Author

tmiotto commented May 17, 2017

@jsmartt could you please take a look and see what could be the best approach to fix it?

@jsmartt
Copy link
Contributor

jsmartt commented May 17, 2017

@tmiotto , I'm super busy for the next few weeks, so won't be able to look at it for a while. Is there anyone on your team that can take a look?

@tmiotto
Copy link
Contributor Author

tmiotto commented May 17, 2017

@jsmartt Oh sorry, I can check it.

I was just wondering if you had a prompt answer on this.

@tmiotto tmiotto self-assigned this May 17, 2017
@jsmartt
Copy link
Contributor

jsmartt commented May 17, 2017

I don't. I looked through the tags of the SDK, and I don't see any release that has that method, so I'm not sure where that came from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants