Cloud Spanner Spring Data: close resources on Unknown errors #456
Labels
Comments
|
Obsolete; per upstream issue Unknown did not become retriable. |
prash-mi
pushed a commit
that referenced
this issue
Jun 20, 2023
Adding Spanner JSON Type support JSON support is present in Client library since 6.12.0 release. This PR intend to add JSON support to our repo. Note that ARRAY support is not included and is intended as a follow-up PR to this. (created issue to track #458) The major changes include: - Add a JsonWrapper class. - Add binder and decoder. - Add String to JsonWrapper for read. - Add to r2dbc sample and spring data r2dbc sample - README docs - register JsonWrapper.class as simple type in spring data dialect. - register converters to/from Map in spring data dialect as default converters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When googleapis/java-spanner-jdbc#455 is merged, Spring Data integration needs to be updated to avoid leaking resources. Currently we handle the
Abortedstatus manually to close the transaction manager, since Spring Data integration does not do automatic retries. IfUnknownbecomes a retryable status in the client library, the transaction manager will no longer be automatically closed for it and will have to be handled in this project.See #251 and #250 for context.
The text was updated successfully, but these errors were encountered: