From c6a6d98a65310306c13a374a139d7a72385473fa Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Tue, 29 Oct 2024 12:12:09 -0400 Subject: [PATCH 01/20] spelling: abandon Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../basicacmgkehubfeaturemembership/dependencies.yaml | 2 +- .../fullacmgkehubfeaturemembership/dependencies.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/basicacmgkehubfeaturemembership/dependencies.yaml b/pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/basicacmgkehubfeaturemembership/dependencies.yaml index 0af5172224..d6a146baf7 100644 --- a/pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/basicacmgkehubfeaturemembership/dependencies.yaml +++ b/pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/basicacmgkehubfeaturemembership/dependencies.yaml @@ -87,7 +87,7 @@ kind: GKEHubFeature metadata: name: gkehubfeature-basic-acm-${uniqueId} annotations: - # Abondon the feature resource as it is global within a project and we would hit issues when running two tests in parallel. + # Abandon the feature resource as it is global within a project and we would hit issues when running two tests in parallel. cnrm.cloud.google.com/deletion-policy: "abandon" spec: projectRef: diff --git a/pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/fullacmgkehubfeaturemembership/dependencies.yaml b/pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/fullacmgkehubfeaturemembership/dependencies.yaml index e28048ab52..b53b582a24 100644 --- a/pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/fullacmgkehubfeaturemembership/dependencies.yaml +++ b/pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/fullacmgkehubfeaturemembership/dependencies.yaml @@ -87,7 +87,7 @@ kind: GKEHubFeature metadata: name: gkehubfeature-full-acm-${uniqueId} annotations: - # Abondon the feature resource as it is global within a project and we would hit issues when running two tests in parallel. + # Abandon the feature resource as it is global within a project and we would hit issues when running two tests in parallel. cnrm.cloud.google.com/deletion-policy: "abandon" spec: projectRef: From b9ca509f75a9088654506d8b4e2791a0354f67e4 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 15:16:49 -0400 Subject: [PATCH 02/20] spelling: accessible Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- crds/container_v1beta1_containercluster.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crds/container_v1beta1_containercluster.yaml b/crds/container_v1beta1_containercluster.yaml index ff28cd3dd1..f24e7adcce 100644 --- a/crds/container_v1beta1_containercluster.yaml +++ b/crds/container_v1beta1_containercluster.yaml @@ -868,7 +868,7 @@ spec: type: object type: array gcpPublicCidrsAccessEnabled: - description: Whether master is accessbile via Google Compute Engine + description: Whether master is accessible via Google Compute Engine Public IP addresses. type: boolean type: object From b57836c2bc69b65f564afbfb4a70772de241625e Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:14:18 -0400 Subject: [PATCH 03/20] spelling: account Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- experiments/compositions/samples/AttachedAKS/aks-charlie.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experiments/compositions/samples/AttachedAKS/aks-charlie.md b/experiments/compositions/samples/AttachedAKS/aks-charlie.md index 894b771cc3..6570429137 100644 --- a/experiments/compositions/samples/AttachedAKS/aks-charlie.md +++ b/experiments/compositions/samples/AttachedAKS/aks-charlie.md @@ -34,7 +34,7 @@ gcloud iam service-accounts add-iam-policy-binding ${TEAM_GSA_EMAIL} \ --condition None ``` -## Grant ASO permission for the GCP service accout used by this team +## Grant ASO permission for the GCP service account used by this team This step follows the [following documentation](setup-Azure-ASO.md#create-a-gcp-service-account) ``` From 8e0462a70d61024ae41676498cf7076076065949 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:14:24 -0400 Subject: [PATCH 04/20] spelling: acquiring Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- config/tests/samples/create/samples.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/tests/samples/create/samples.go b/config/tests/samples/create/samples.go index e1f46e86ba..91eaf51875 100644 --- a/config/tests/samples/create/samples.go +++ b/config/tests/samples/create/samples.go @@ -499,7 +499,7 @@ func updateProjectResourceWithExistingResourceIDs(t *testing.T, unstructs []*uns if err != nil { t.Fatalf("error getting billingAccountRef: %v", err) } - // We cannot dynamically create GCP project with billingAccountRef, acquring pre-created project instead. + // We cannot dynamically create GCP project with billingAccountRef, acquiring pre-created project instead. if found && b != "" { annotations := u.GetAnnotations() if annotations == nil { From 5b8217dfe5521541d54d33bf65ae5d8b76e6d75a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:14:32 -0400 Subject: [PATCH 05/20] spelling: actual Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- pkg/controller/direct/gkehub/featuremembership_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/direct/gkehub/featuremembership_controller.go b/pkg/controller/direct/gkehub/featuremembership_controller.go index d819c71692..8b507ff8d9 100644 --- a/pkg/controller/direct/gkehub/featuremembership_controller.go +++ b/pkg/controller/direct/gkehub/featuremembership_controller.go @@ -240,7 +240,7 @@ func (a *gkeHubAdapter) Update(ctx context.Context, updateOp *directbase.UpdateO log := klog.FromContext(ctx).WithName(ctrlName) log.V(2).Info("updating object", "u", u) actual := a.actual.MembershipSpecs[a.membershipID] - // There are no output fields in the api Object, so we can compare the desired and the actaul directly. + // There are no output fields in the api Object, so we can compare the desired and the actual directly. if !reflect.DeepEqual(a.desired.Configmanagement, actual.Configmanagement) || !reflect.DeepEqual(a.desired.Policycontroller, actual.Policycontroller) || !reflect.DeepEqual(a.desired.Mesh, actual.Mesh) { log.V(2).Info("diff detected, patching gkehubfeaturemembership") if _, err := a.patchMembershipSpec(ctx); err != nil { From c7a1a6f2eef24ab2195e9fefd417a8d1d2c2d182 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Tue, 29 Oct 2024 09:19:41 -0400 Subject: [PATCH 06/20] spelling: actuation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- pkg/controller/resourceactuation/resourceactuation.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/resourceactuation/resourceactuation.go b/pkg/controller/resourceactuation/resourceactuation.go index 1c1064eb1a..a7c72ababf 100644 --- a/pkg/controller/resourceactuation/resourceactuation.go +++ b/pkg/controller/resourceactuation/resourceactuation.go @@ -44,7 +44,7 @@ func DecideActuationMode(cc opv1beta1.ConfigConnector, ccc opv1beta1.ConfigConne return opv1beta1.DefaultActuationMode() } -// ShouldSkip skips a resource actuatation if the ReconcileIntervalInSecondsAnnotation = 0 and the KRM resource has not changed since its last UpToDate. +// ShouldSkip skips a resource actuation if the ReconcileIntervalInSecondsAnnotation = 0 and the KRM resource has not changed since its last UpToDate. // This will disable drift correction on corresponding GCP resources since the reconcileInterval is set to 0. func ShouldSkip(u *unstructured.Unstructured) (bool, error) { generation, found, err := unstructured.NestedInt64(u.Object, "metadata", "generation") From e5495b5d65d7d1da4270668cce80765190604076 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:14:54 -0400 Subject: [PATCH 07/20] spelling: already Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- pkg/ready/ready.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/ready/ready.go b/pkg/ready/ready.go index 9a9afd03e4..58150a0277 100644 --- a/pkg/ready/ready.go +++ b/pkg/ready/ready.go @@ -30,7 +30,7 @@ var ready = false // SetContainerAsReady sets up an HTTP server for the readiness probe to check func SetContainerAsReady() { - // Avoid starting up another HTTP server if we had alread started one to + // Avoid starting up another HTTP server if we had already started one to // avoid a port conflict error which would cause an application crash due // to the logging.Fatal() call below. if ready { From e73a44c2e2b88a041affccc4706e40c0cce3e0b4 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:19:18 -0400 Subject: [PATCH 08/20] spelling: ambiguous Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- pkg/k8s/meta.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/k8s/meta.go b/pkg/k8s/meta.go index 17dc3d4315..dced5881cf 100644 --- a/pkg/k8s/meta.go +++ b/pkg/k8s/meta.go @@ -292,7 +292,7 @@ func GetContainerAnnotation(annotations map[string]string, containerTypes []core continue } if found { - return "", "", fmt.Errorf("ambiguious container annotation: found for %v and %v", containerType, c) + return "", "", fmt.Errorf("ambiguous container annotation: found for %v and %v", containerType, c) } containerVal = val containerType = c From 1020cb764d4ce1bc6d7e7ab0964968a373b502c4 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 30 Oct 2024 10:54:50 -0400 Subject: [PATCH 09/20] spelling: an Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6e5d5af91e..437a574d6e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -367,7 +367,7 @@ can run it locally on your dev machine with the steps below. If you are adding a new resource, you need to follow the steps in [NewResourceFromTerraform.md](README.ChangingTerraform.md) to make code changes, add test data, and run the tests for your resource. -If you are working on a existing resource, test yaml should exist under +If you are working on an existing resource, test yaml should exist under ./pkg/test/resourcefixture/testdata/basic, you can run the test command directly to make sure the test can still pass. Example command: From 3e9a2e4eed648cf7fed305b45e8c02d063e32b91 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:15:02 -0400 Subject: [PATCH 10/20] spelling: analyze Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../pkg/commands/updatetypes/updatetypescommand.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/tools/controllerbuilder/pkg/commands/updatetypes/updatetypescommand.go b/dev/tools/controllerbuilder/pkg/commands/updatetypes/updatetypescommand.go index a08bb7ed25..d710a9848c 100644 --- a/dev/tools/controllerbuilder/pkg/commands/updatetypes/updatetypescommand.go +++ b/dev/tools/controllerbuilder/pkg/commands/updatetypes/updatetypescommand.go @@ -143,7 +143,7 @@ func (u *TypeUpdater) Run() error { return nil } -// anaylze finds the new field, its parent message, and all dependent messages that need to be generated. +// analyze finds the new field, its parent message, and all dependent messages that need to be generated. func (u *TypeUpdater) analyze() error { parentMessage, newField, err := findNewField(u.opts.ProtoSourcePath, u.opts.parentMessageFullName, u.opts.newField) if err != nil { From 3ab40008447da836c57abd0685acfe12e6ecce3c Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:09:22 -0400 Subject: [PATCH 11/20] spelling: and Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../samples/configconnector_cluster_mode_workload_identity.yaml | 2 +- operator/config/samples/configconnectorcontext_sample.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/operator/config/samples/configconnector_cluster_mode_workload_identity.yaml b/operator/config/samples/configconnector_cluster_mode_workload_identity.yaml index c9cabfc52d..09a6ab9422 100644 --- a/operator/config/samples/configconnector_cluster_mode_workload_identity.yaml +++ b/operator/config/samples/configconnector_cluster_mode_workload_identity.yaml @@ -18,5 +18,5 @@ metadata: name: configconnector.core.cnrm.cloud.google.com spec: mode: cluster - # Replace ${GSA?} with your service account's name and and ${PROJECT_ID?} with your project ID. + # Replace ${GSA?} with your service account's name and ${PROJECT_ID?} with your project ID. googleServiceAccount: "${GSA?}@${PROJECT_ID?}.iam.gserviceaccount.com" \ No newline at end of file diff --git a/operator/config/samples/configconnectorcontext_sample.yaml b/operator/config/samples/configconnectorcontext_sample.yaml index f6731e9a26..70f104ab94 100644 --- a/operator/config/samples/configconnectorcontext_sample.yaml +++ b/operator/config/samples/configconnectorcontext_sample.yaml @@ -17,5 +17,5 @@ kind: ConfigConnectorContext metadata: name: configconnectorcontext.core.cnrm.cloud.google.com spec: - # Replace ${GSA?} with your service account's name and and ${PROJECT_ID?} with your project ID. + # Replace ${GSA?} with your service account's name and ${PROJECT_ID?} with your project ID. googleServiceAccount: "${GSA?}@${PROJECT_ID?}.iam.gserviceaccount.com" From dd3b6469672a77641a858b1983226b963c9da0c5 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Tue, 29 Oct 2024 11:15:40 -0400 Subject: [PATCH 12/20] spelling: annotation composition Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../composition/internal/controller/expander_reconciler.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/experiments/compositions/composition/internal/controller/expander_reconciler.go b/experiments/compositions/composition/internal/controller/expander_reconciler.go index ea841c36aa..c4f1c2a518 100644 --- a/experiments/compositions/composition/internal/controller/expander_reconciler.go +++ b/experiments/compositions/composition/internal/controller/expander_reconciler.go @@ -226,9 +226,9 @@ func (r *ExpanderReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c _, exist := inputcr.GetAnnotations()["composition-expander-debug-logs"] if exist { expanderDebugLogsEnabled = true - logger.Info("annotation'composition-expander-debug-logs' is turned on.") + logger.Info("annotation 'composition-expander-debug-logs' is turned on.") } - logger.Info("annotation'composition-expander-debug-logs' is turned off.") + logger.Info("annotation 'composition-expander-debug-logs' is turned off.") // Write out the (in-order) stages to the plan as a reference for later when we need to delete resources. stagesEvaluated := []string{} From ad07d73df29f2019cd6099ab5445c30abc005a53 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:15:13 -0400 Subject: [PATCH 13/20] spelling: annotation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../compositions/Design Notes/Deletion of Expanded Resources.md | 2 +- pkg/test/controller/reconcile.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/experiments/compositions/Design Notes/Deletion of Expanded Resources.md b/experiments/compositions/Design Notes/Deletion of Expanded Resources.md index 9f1a2e7100..8c052aaea1 100644 --- a/experiments/compositions/Design Notes/Deletion of Expanded Resources.md +++ b/experiments/compositions/Design Notes/Deletion of Expanded Resources.md @@ -27,7 +27,7 @@ reference: ## Abandon chioce -We should allow the choice to abandon the expanded resources when the Input API is deleted. This could be done via an annotaton on the Input API object. +We should allow the choice to abandon the expanded resources when the Input API is deleted. This could be done via an annotation on the Input API object. ## POC decisions diff --git a/pkg/test/controller/reconcile.go b/pkg/test/controller/reconcile.go index ae92f01812..689fb75be2 100644 --- a/pkg/test/controller/reconcile.go +++ b/pkg/test/controller/reconcile.go @@ -282,7 +282,7 @@ tryAgain: return nil } - return fmt.Errorf("cannot set project id annotatation value to %q: the annotation already contained a value of %q", projectID, val) + return fmt.Errorf("cannot set project id annotation value to %q: the annotation already contained a value of %q", projectID, val) } k8s.SetAnnotation(k8s.ProjectIDAnnotation, projectID, &ns) err := c.Update(ctx, &ns) From bb823818f0eacdc4a10f0a365b1d3056442c0761 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 15:17:52 -0400 Subject: [PATCH 14/20] spelling: associated Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- apis/discoveryengine/v1alpha1/discoveryenginedatastore_types.go | 2 +- ...yenginedatastores.discoveryengine.cnrm.cloud.google.com.yaml | 2 +- .../discoveryengine/v1alpha1/discoveryenginedatastore_types.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apis/discoveryengine/v1alpha1/discoveryenginedatastore_types.go b/apis/discoveryengine/v1alpha1/discoveryenginedatastore_types.go index 8dbd64b439..890906bbae 100644 --- a/apis/discoveryengine/v1alpha1/discoveryenginedatastore_types.go +++ b/apis/discoveryengine/v1alpha1/discoveryenginedatastore_types.go @@ -98,7 +98,7 @@ type DiscoveryEngineDataStoreStatus struct { // +kcc:proto=google.cloud.discoveryengine.v1.DataStore type DiscoveryEngineDataStoreObservedState struct { // Output only. The id of the default - // [Schema][google.cloud.discoveryengine.v1.Schema] asscociated to this data + // [Schema][google.cloud.discoveryengine.v1.Schema] associated to this data // store. DefaultSchemaID *string `json:"defaultSchemaID,omitempty"` diff --git a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_discoveryenginedatastores.discoveryengine.cnrm.cloud.google.com.yaml b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_discoveryenginedatastores.discoveryengine.cnrm.cloud.google.com.yaml index 36d0c5999f..eeb6980193 100644 --- a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_discoveryenginedatastores.discoveryengine.cnrm.cloud.google.com.yaml +++ b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_discoveryenginedatastores.discoveryengine.cnrm.cloud.google.com.yaml @@ -242,7 +242,7 @@ spec: type: string defaultSchemaID: description: Output only. The id of the default [Schema][google.cloud.discoveryengine.v1.Schema] - asscociated to this data store. + associated to this data store. type: string type: object type: object diff --git a/pkg/clients/generated/apis/discoveryengine/v1alpha1/discoveryenginedatastore_types.go b/pkg/clients/generated/apis/discoveryengine/v1alpha1/discoveryenginedatastore_types.go index 000a842a02..373778b8a6 100644 --- a/pkg/clients/generated/apis/discoveryengine/v1alpha1/discoveryenginedatastore_types.go +++ b/pkg/clients/generated/apis/discoveryengine/v1alpha1/discoveryenginedatastore_types.go @@ -131,7 +131,7 @@ type DatastoreObservedStateStatus struct { // +optional CreateTime *string `json:"createTime,omitempty"` - /* Output only. The id of the default [Schema][google.cloud.discoveryengine.v1.Schema] asscociated to this data store. */ + /* Output only. The id of the default [Schema][google.cloud.discoveryengine.v1.Schema] associated to this data store. */ // +optional DefaultSchemaID *string `json:"defaultSchemaID,omitempty"` } From 4fb8166262ed0bd29ebf81ad5c29ffe18075020d Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Tue, 29 Oct 2024 21:23:47 -0400 Subject: [PATCH 15/20] spelling: asymptotic Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- tests/e2e/script_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/e2e/script_test.go b/tests/e2e/script_test.go index 3253f2d639..e1f5a6d54b 100644 --- a/tests/e2e/script_test.go +++ b/tests/e2e/script_test.go @@ -239,7 +239,7 @@ func TestE2EScript(t *testing.T) { t.Fatalf("timed out looking for value %s in http log", sval) stopWaiting = true case <-ticker.C: - // todo(acpana): find better asympotatic approach + // todo(acpana): find better asymptotic approach for _, l := range h.Events.HTTPEvents { if strings.Contains(l.Response.Body, sval) { stopWaiting = true From 8784e4f908d4bdf8f21be8a03cca560611aa1b67 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:19:38 -0400 Subject: [PATCH 16/20] spelling: autopilot Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- operator/scripts/update-kcc-manifest/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator/scripts/update-kcc-manifest/main.go b/operator/scripts/update-kcc-manifest/main.go index 880f5065f5..a074957c60 100644 --- a/operator/scripts/update-kcc-manifest/main.go +++ b/operator/scripts/update-kcc-manifest/main.go @@ -403,7 +403,7 @@ func kustomizeBuild(operatorSrcRoot string) { buildPath = path.Join(operatorSrcRoot, baseDir, "kcc", "install-bundle-namespaced") buildNamespacedMode(operatorSrcRoot, buildPath, output, false) - // autpilot namespaced mode + // autopilot namespaced mode buildPath = path.Join(operatorSrcRoot, baseDir, "kcc", "install-bundle-autopilot-namespaced") buildNamespacedMode(operatorSrcRoot, buildPath, output, true) } From ff9c83b7af7a2c8386117fcf6c450e4720822b1b Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:19:58 -0400 Subject: [PATCH 17/20] spelling: availability Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- pkg/controller/direct/sql/sqlinstance_defaults.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/direct/sql/sqlinstance_defaults.go b/pkg/controller/direct/sql/sqlinstance_defaults.go index 07e5e9a351..ac1837199d 100644 --- a/pkg/controller/direct/sql/sqlinstance_defaults.go +++ b/pkg/controller/direct/sql/sqlinstance_defaults.go @@ -40,7 +40,7 @@ func ApplySQLInstanceGCPDefaults(in *krm.SQLInstance, out *api.DatabaseInstance, out.Settings.AuthorizedGaeApplications = make([]string, 0) } if in.Spec.Settings.AvailabilityType == nil { - // GCP default AvailailbilityType is ZONAL. + // GCP default AvailabilityType is ZONAL. out.Settings.AvailabilityType = "ZONAL" } if in.Spec.Settings.BackupConfiguration == nil && actual != nil && !actual.Settings.BackupConfiguration.Enabled { From 38f05212921a9288bdf711696b0cfd671b5ade28 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 18:19:46 -0400 Subject: [PATCH 18/20] spelling: available Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- experiments/compositions/samples/AttachedAKS/setup-Azure-ASO.md | 2 +- experiments/compositions/samples/AttachedEKS/setup-AWS-ACK.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/experiments/compositions/samples/AttachedAKS/setup-Azure-ASO.md b/experiments/compositions/samples/AttachedAKS/setup-Azure-ASO.md index f81a75ef87..933261f349 100644 --- a/experiments/compositions/samples/AttachedAKS/setup-Azure-ASO.md +++ b/experiments/compositions/samples/AttachedAKS/setup-Azure-ASO.md @@ -1,6 +1,6 @@ # Set up Azure Service Operator v2 (ASO) -Note: ASO support is only availabe for GCP managed [Config +Note: ASO support is only available for GCP managed [Config Connector](https://cloud.google.com/config-connector/docs/overview). Here is an overview of the ASO setup process: diff --git a/experiments/compositions/samples/AttachedEKS/setup-AWS-ACK.md b/experiments/compositions/samples/AttachedEKS/setup-AWS-ACK.md index f408d44f12..e5dce44130 100644 --- a/experiments/compositions/samples/AttachedEKS/setup-AWS-ACK.md +++ b/experiments/compositions/samples/AttachedEKS/setup-AWS-ACK.md @@ -1,6 +1,6 @@ # Set up AWS Controllers for Kubernetes (ACK) -Note: ACK support is only availabe for GCP managed [Config +Note: ACK support is only available for GCP managed [Config Connector](https://cloud.google.com/config-connector/docs/overview). Here is an overview of the ACK setup process: From dbb3e4060af15518e6f70409272d037344249f59 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 17:24:01 -0400 Subject: [PATCH 19/20] spelling: behavior Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- crds/vertexai_v1alpha1_vertexaifeaturestoreentitytype.yaml | 2 +- docs/develop-resources/api-conventions/external-reference.md | 2 +- docs/develop-resources/api-conventions/resource-reference.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crds/vertexai_v1alpha1_vertexaifeaturestoreentitytype.yaml b/crds/vertexai_v1alpha1_vertexaifeaturestoreentitytype.yaml index 9633eebd8f..2f35bccf0e 100644 --- a/crds/vertexai_v1alpha1_vertexaifeaturestoreentitytype.yaml +++ b/crds/vertexai_v1alpha1_vertexaifeaturestoreentitytype.yaml @@ -114,7 +114,7 @@ spec: type: string state: description: |- - Whether to enable / disable / inherite default hebavior for import features analysis. The value must be one of the values below: + Whether to enable / disable / inherite default behavior for import features analysis. The value must be one of the values below: * DEFAULT: The default behavior of whether to enable the monitoring. EntityType-level config: disabled. * ENABLED: Explicitly enables import features analysis. EntityType-level config: by default enables import features analysis for all Features under it. * DISABLED: Explicitly disables import features analysis. EntityType-level config: by default disables import features analysis for all Features under it. diff --git a/docs/develop-resources/api-conventions/external-reference.md b/docs/develop-resources/api-conventions/external-reference.md index 884827b413..4eec598d40 100644 --- a/docs/develop-resources/api-conventions/external-reference.md +++ b/docs/develop-resources/api-conventions/external-reference.md @@ -46,7 +46,7 @@ The `status.externalRef` shall use the [cloud asset inventory](https://cloud.go ### Backward compatibiltiy for TF/DCL based reconcilers -The existing TF-based and DCL-based reconciliation treats the `spec.resourceID` as the single Source of Truth to identify a GCP resource. It writes back the `spec.resourceID` after reconciliation. Here are [the known problems](/~https://github.com/GoogleCloudPlatform/k8s-config-connector/issues/2765). Config Connector will keep the bahavior of these resources, until they are migrated to the Direct reconciler. +The existing TF-based and DCL-based reconciliation treats the `spec.resourceID` as the single Source of Truth to identify a GCP resource. It writes back the `spec.resourceID` after reconciliation. Here are [the known problems](/~https://github.com/GoogleCloudPlatform/k8s-config-connector/issues/2765). Config Connector will keep the behavior of these resources, until they are migrated to the Direct reconciler. diff --git a/docs/develop-resources/api-conventions/resource-reference.md b/docs/develop-resources/api-conventions/resource-reference.md index 19dcdb0c54..ba7320f123 100644 --- a/docs/develop-resources/api-conventions/resource-reference.md +++ b/docs/develop-resources/api-conventions/resource-reference.md @@ -174,7 +174,7 @@ For example, the `computeForwardingRule` has the `ComputeAddress` reference whic ### Rule 1 -We will continue supporting the existing bebavior when migrating to the Direct Resource. +We will continue supporting the existing behavior when migrating to the Direct Resource. ### Rule 2 From c0173c793017a9d9fe39993f9a35f3435f0cacce Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 28 Oct 2024 15:03:56 -0400 Subject: [PATCH 20/20] spelling: being Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- crds/compute_v1beta1_computeinstancegroupmanager.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crds/compute_v1beta1_computeinstancegroupmanager.yaml b/crds/compute_v1beta1_computeinstancegroupmanager.yaml index 995d6e4842..ab3d2e280d 100644 --- a/crds/compute_v1beta1_computeinstancegroupmanager.yaml +++ b/crds/compute_v1beta1_computeinstancegroupmanager.yaml @@ -620,7 +620,7 @@ spec: recreating: description: '[Output Only] The number of instances in the managed instance group that are scheduled to be recreated or are currently - being being recreated. Recreating an instance deletes the existing + being recreated. Recreating an instance deletes the existing root persistent disk and creates a new disk from the image that is defined in the instance template.' format: int64