Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify namespace for elastica modules to avoid namespace confusion and clutter #193

Closed
bhosale2 opened this issue Aug 30, 2022 · 10 comments · Fixed by #238
Closed

Clarify namespace for elastica modules to avoid namespace confusion and clutter #193

bhosale2 opened this issue Aug 30, 2022 · 10 comments · Fixed by #238
Assignees
Labels
discussion Topic that needs to be discussed. enhancement New feature or request good first issue Good for newcomers prio:medium Priority level: medium
Milestone

Comments

@bhosale2
Copy link
Collaborator

Currently, in example cases, the modules from elastica are imported directly as from elastica import *. This can become an issue when using elastica across packages (where elastica is a plugin), where modules from other packages can collide in namings with the modules from elastica. To avoid this, it may be helpful to use functionalities in elastica as:

import elastica as ea; ea.Damping(....) to make it explicit where the functionality comes from.

@skim0119 and @armantekinalp thoughts?

@bhosale2 bhosale2 added enhancement New feature or request good first issue Good for newcomers discussion Topic that needs to be discussed. prio:medium Priority level: medium labels Aug 30, 2022
@bhosale2 bhosale2 added this to the Version 0.3.1 milestone Aug 30, 2022
@armantekinalp
Copy link
Contributor

I think it is a good suggestion.

@skim0119
Copy link
Collaborator

Last point on pep8

@armantekinalp
Copy link
Contributor

Yes it is still open

@Rahul-JOON
Copy link
Contributor

Rahul-JOON commented Feb 18, 2023

If this issue is still open, I would like to be assigned to it. @armantekinalp @bhosale2

@Deep-Rai-08
Copy link

Is this issue is open?? @armantekinalp

@skim0119
Copy link
Collaborator

@Deep-Rai-08 The issue is still open. Feel free to make a PR.

@bhosale2
Copy link
Collaborator Author

A note to everyone interested in this issue: if you plan to work on it please either assign yourself to the issue or let us know that you wish to be assigned to the issue.

@amangupta201
Copy link

amangupta201 commented Mar 20, 2023

@bhosale2
NameSpaces can be a great way to sort and clarify the elastica modules
Please assign me to this issue

@AsadNizami
Copy link
Contributor

AsadNizami commented Mar 27, 2023

Hi, is anyone still working on the issue? If not I'd like to work on it. @armantekinalp

@bhosale2 bhosale2 linked a pull request Mar 27, 2023 that will close this issue
@bhosale2
Copy link
Collaborator Author

Closed via #238.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Topic that needs to be discussed. enhancement New feature or request good first issue Good for newcomers prio:medium Priority level: medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants