Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS setup #102

Closed
bhosale2 opened this issue Jun 1, 2022 · 2 comments · Fixed by #115
Closed

CODEOWNERS setup #102

bhosale2 opened this issue Jun 1, 2022 · 2 comments · Fixed by #115
Labels
enhancement New feature or request
Milestone
Version 0.3

Comments

@bhosale2
Copy link
Collaborator

bhosale2 commented Jun 1, 2022

For automatic targeted reviewer requests, we should consider having a CODEOWNERS file like /~https://github.com/tp5uiuc/elasticapp/blob/master/docs/CODEOWNERS.
@bhosale2 bhosale2 added the enhancement New feature or request label Jun 1, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jun 1, 2022
@skim0119
Copy link
Collaborator

skim0119 commented Jun 2, 2022

I like the idea, but do you think our team is big enough that we need this? We only have 3 active maintainers, and practically we get 1~2 external issues per month.

@bhosale2 bhosale2 mentioned this issue Jun 22, 2022
Merged
@bhosale2 bhosale2 linked a pull request Jun 22, 2022 that will close this issue
(#102) Codeowners setup #115
Merged
bhosale2 added a commit that referenced this issue Jun 23, 2022
@bhosale2
Merge pull request #115 from bhosale2/102_codeowners_setup
d138ae9 
(#102) Codeowners setup
@bhosale2
Copy link
Collaborator Author

Resolved by #115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging a pull request may close this issue.

(#102) Codeowners setup bhosale2/PyElastica
2 participants
@skim0119 @bhosale2