Invalid text position after batch renaming

[naveensingh]

Checklist

• I can reproduce the bug with the latest versions.
• I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• I have read the FAQs inside the app (Menu -> About -> FAQs), in the README and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report may get dismissed otherwise.
• This issue contains only one bug.

Affected Android/Custom ROM version

All versions

Affected device model

All devices

How did you install the apps?

GitHub releases

Which apps are affected?

Gallery, File Manager

Steps to reproduce the bug

1. Select multiple files
2. Tap Rename
3. Enter "test" in the "String to add" field
4. Select "Append filenames"
5. Tap OK

Expected behavior

Files should be renamed to something like test[Original file name] i.e. the filename should be appended as indicated by Append filenames option.

Actual behavior

Files are renamed to [Original file name]test.

Screenshots/Screen recordings

No response

Additional information

Original issue: FossifyOrg/Gallery#405

The whole thing should be reworked for better UI/UX.

[tswistak]

Right under "Append filenames" there's "Prepend filenames" which means that the written text will prepend filenames, so it works just like your expected behavior. Unless there are errors in translations (which can be made because people on Weblate may not know the context), the English one is pretty obvious IMHO.

Maybe it would be enough to add a hint how both options will behave?

[naveensingh]

In my opinion, the behavior is reversed in both cases.

Append filenames: Append means 'add something at the end of something else' so here, the filename becomes the object that is added at the end.

Prepend filenames: Prepend means 'add something at the start of something else' so here, the filename becomes the object that is added at the start.

But evidently, the current strings are a little too open to interpretation so I think the options should be reworded to something simpler:

• Add text before filenames
• Add text after filenames

[chesio]

Alternatively (and considering the label in input field says "String to add"):

• Append string to filenames
• Prepend string to filenames

I kinda prefer these two, because the distinction between actions is in the first word already, so it's less cognitive work to do... 😄

[naveensingh]

Well... append, prepend, etc. are common/intuitive terms for us as developers but they are not commonly used in everyday English. Speaking of common, maybe it's the 'string' that needs to go ;)