-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jackson-dataformats-csv: copy over recent jackson-core changes #312
Comments
@cowtowncoder thanks for merging the fast parser/generator support - this issue also includes FasterXML/jackson-core#757 - is that worth pursuing? That remaining issue was the one where some edge case floats are not parsed correctly because they are first parsed as doubles and then cast to float instead of being parsed explicitly as floats (2 conversions when there should just be 1). |
@pjfanning np, thank you for all these cool contributions. As to remaining edge cases, yes, I think those would be good to address. Or at very least add (failing) tests cases where necessary. Then we could see how easy fixes are. I also hope to get Jackson 3.0 development back on track. The one blocking thing right now is that I want to fully decide actual Java Package and Maven group ids.
Oh yeah, Jackson 3.x really has no relevance to all parser work here. Just something I'll mention as relative near-term focus, possibly competing with 2.14 release. But I also do want to get 2.14.0 out quite soon -- all the must-haves I had are in (basically just the new |
@cowtowncoder I think this can be marked as resolved now |
jackson-dataformats-csv has its own copy of jackson-core NumberInput and TextBuffer classes.
jackson-core changes that could be of use include:
StreamReadFeature.USE_FAST_DOUBLE_PARSER
jackson-core#577The text was updated successfully, but these errors were encountered: