Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow explicit JsonSubTypes repeated names check #204

Closed
ancane opened this issue May 29, 2022 · 1 comment
Closed

Allow explicit JsonSubTypes repeated names check #204

ancane opened this issue May 29, 2022 · 1 comment
Milestone
2.14.0

Comments

@ancane
Copy link
Contributor

ancane commented May 29, 2022

Hi) Got a project at hand, using tons of JsonSubTypes with logical short names defined for the brevity of serialized data. Usually, it's pretty hard to manually check there are no repeated name/names aliases defined when adding a new subtype. I would like to explicitly state and validate there are no repeated subtype names defined. Please, consider related PR for this matter and suggest the best way to do this if PR is not good enough. I Will also PR the databind repo with the implementation of the check. Also please advise, how to add this to the 2.12 branch if that's at all possible. Cheers!
ancane added a commit to ancane/jackson-annotations that referenced this issue May 29, 2022
@ancane
added allowRepeatedNames flag, to be able to track down repeated logi…
ef55196 
…cal type names FasterXML#204
@ancane ancane mentioned this issue May 29, 2022
Closed
ancane added a commit to ancane/jackson-annotations that referenced this issue Aug 1, 2022
@ancane
added failOnRepeatedNames flag, to be able to track down repeated log…
9ee515c 
…ical type names FasterXML#204
cowtowncoder pushed a commit that referenced this issue Aug 2, 2022
@ancane
added failOnRepeatedNames flag, to be able to track down repeated log…
0da3e6e 
…ical type names #204 (#205)
cowtowncoder added a commit that referenced this issue Aug 2, 2022
@cowtowncoder
Add release notes wrt #204
d15b34e
@cowtowncoder cowtowncoder added this to the 2.14.0 milestone Aug 2, 2022
@cowtowncoder cowtowncoder changed the title FEATURE: explicit JsonSubTypes repeated names check Allow explicit JsonSubTypes repeated names check Aug 2, 2022
@cowtowncoder
Copy link
Member

Was implemented via FasterXML/jackson-databind#3500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
2 participants
@cowtowncoder @ancane