Company Cards - Remove Direct feed display RBR

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.7-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5666347
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition: The user is an admin of a workspace that has company cards enabled. The user has already added a pending Master card before.

1. Open https://staging.new.expensify.com/
2. Click on the Card selector
3. Click on Add card
4. Click on the American Express option
5. Select the American Express Business Cards
6. Verify a window opens to the American Express website to sign in
7. Enter the credentials "American Express - Work - Direct Feed" from 1Password
8. Select the 2 available cards and confirm
9. From the Company cards page assign card a card to the admin and finish the flow
10. Click on the Settings button on the Direct card feed
11. Click on the Remove card feed button

Expected Result:

The app should display a warning message about the card still assigned to the admin user.

Actual Result:

No warning display when removing the Direct card and after removing the Direct card feed with a card assigned to the admin displays an RBR on the Card selector at the pending card but clicking on it only opens the card selector

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• [ x ] iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6757294_1740729747193.RDR_Remove_DirectFeed.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No warning display when removing the Direct card and after removing the Direct card feed with a card assigned to the admin displays an RBR on the Card selector at the pending card but clicking on it only opens the card selector

What is the root cause of that problem?

App/src/libs/CardUtils.ts

Line 522 in 73dbe59

function checkIfFeedConnectionIsBroken(feedCards: Record<string, Card> | undefined, feedToExclude?: string): boolean {

checkIfFeedConnectionIsBroken returns true because the card of the deleted feed still exists. It makes the RBR display

What changes do you think we should make in order to solve the problem?

We should only allow users to remove the feed if all cards are unassigned

When users are trying to remove feeds before unassigning all cards, we can display a modal to warn them

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Only display the delete button if all cards are unassigned

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.