Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom enchantments in /kitcreate and /kit #3943

Open
SNokerYT opened this issue Jan 25, 2021 · 4 comments
Open

Support custom enchantments in /kitcreate and /kit #3943

SNokerYT opened this issue Jan 25, 2021 · 4 comments
Labels
bug: confirmed Confirmed bugs in EssentialsX.

Comments

@SNokerYT
Copy link

i have a problem with essentials kits - When i Create a kit with a Glow on item and order this kit the glow will disappear from item
test1

@SNokerYT SNokerYT added the bug: unconfirmed Potential bugs that need replicating to verify. label Jan 25, 2021
@Chew
Copy link
Member

Chew commented Jan 26, 2021

Great start but you're still missing most of the template...

Information

Full output of /ess version:


Server startup log:

EssentialsX config:

Details

Description:

Steps to reproduce:

Expected behavior:

Console stack trace:


Screenshots:

@SNokerYT
Copy link
Author

image
Log | https://justpaste.it/5wfyw
EssentialsX config | https://justpaste.it/4blaa

@JRoy
Copy link
Member

JRoy commented Mar 8, 2021

Could perhaps use the new enchantment providers pending in #3963 to serialize/deserialize enchantments by id/namspace

@JRoy JRoy added bug: confirmed Confirmed bugs in EssentialsX. and removed bug: unconfirmed Potential bugs that need replicating to verify. labels Mar 8, 2021
@pop4959
Copy link
Member

pop4959 commented Mar 9, 2021

I think this is more so an issue with the Essentials item meta not being re-applied to the items that are saved via /kitcreate and then loaded. I'm pretty sure it's also a more widespread issue than just the glow effect.

@JRoy JRoy changed the title Essentials Kit Glow Problem Support custom enchantments in /kitcreate and /kit Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed Confirmed bugs in EssentialsX.
Projects
None yet
Development

No branches or pull requests

4 participants