Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dogstatsd] Make dogstatsd work better with containers #2949

Closed
mikekap opened this issue Oct 23, 2016 · 5 comments
Closed

[dogstatsd] Make dogstatsd work better with containers #2949

mikekap opened this issue Oct 23, 2016 · 5 comments
Milestone

Comments

@mikekap
Copy link
Contributor

mikekap commented Oct 23, 2016

Similar to how service discovery lets you probe metrics (pull), it would be awesome if some integration existed for statsd packets (push). This would likely take the form of adding tags to incoming metrics, similar to host.

Particularly, it would be great if e.g. for kubernetes, the pod name & deployment name were appended as tags. This information can be extracted from the source ip of the message (at least in Kubernetes).

@mikekap mikekap changed the title Make dogstatsd work better with containers [dogstatsd] Make dogstatsd work better with containers Oct 23, 2016
@remh
Copy link

remh commented Oct 25, 2016

Thanks @mikekap this exact idea is already on our roadmap, it might take some time though as we'll need to consolidate a bunch of things for it to happen but we definitely agree on the use case.

@remh remh added this to the Future milestone Oct 25, 2016
@kiyose
Copy link

kiyose commented Dec 22, 2016

We are trying to work around this issue by setting up the kubernetes agent to run on each node via the documented daemonset configuration and also setting up an dogstatsd agent in each namespace, exposing 8125 via service. This runs afoul of at least one issue.

First, the agent that reports the stats may not be on the same host that the service that generated the stats is on. This means that we don't gain any benefit of automatically applied tags and it is harder to trace issues back to a given host.

Second, we have seen issues when we expose 8125 via a HostPort in the daemonset based agent with metrics being intermingled with name. This may be due to our network configuration and we are looking into it.

@danopia
Copy link

danopia commented Apr 13, 2017

I'm running one dogstatsd per application container and want to tag each application's metrics with the app name. I tried setting tags: blah, blah, blah in the datadog.conf file but that doesn't seem to do anything. How can I universally tag all data send through one dogstatsd/forwarder pair?

That would relatively easily let me work around the noted issues here.

@pchristos
Copy link

What's the status of this?

@hkaj
Copy link
Member

hkaj commented Apr 19, 2019

Hi @pchristos
This was implemented recently in agent 6 (not this repo, the new one at datadog-agent ), we're working on documentation right now but if you wanna see how it works here are 3 PRs that should help:

I'm going to close this issue as this won't be done in this repo (which is for the old agent 5). However if you face any issue with this feature do not hesitate to open an issue in datadog-agent.

@hkaj hkaj closed this as completed Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants