Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there a compatible bitmap java lib for clickhouse? #1141

Closed
learn2Pro opened this issue Dec 1, 2022 · 5 comments · Fixed by #1248
Closed

is there a compatible bitmap java lib for clickhouse? #1141

learn2Pro opened this issue Dec 1, 2022 · 5 comments · Fixed by #1248

Comments

@learn2Pro
Copy link

learn2Pro commented Dec 1, 2022

<!-- https://mvnrepository.com/artifact/com.clickhouse/org.roaringbitmap -->
<dependency>
    <groupId>com.clickhouse</groupId>
    <artifactId>org.roaringbitmap</artifactId>
    <version>1.5.0</version>
    <scope>provided</scope>
</dependency>

is this lib available?

@zhicwu
Copy link
Contributor

zhicwu commented Dec 1, 2022

Hi @learn2Pro, are you using a mirror? You can use maven central to check, for example: https://repo1.maven.org/maven2/com/clickhouse/org.roaringbitmap/1.5.0/.

@zhicwu zhicwu added the question label Dec 1, 2022
@learn2Pro
Copy link
Author

Hi @learn2Pro, are you using a mirror? You can use maven central to check, for example: https://repo1.maven.org/maven2/com/clickhouse/org.roaringbitmap/1.5.0/.

i try but not work with this lib, the 64bitmap result still incorrect

@learn2Pro
Copy link
Author

RoaringBitmap/RoaringBitmap#598

already support croaring layout ,should we change ClickHouseBitmap to compatible this?

@learn2Pro
Copy link
Author

should i contribute for this?

@zhicwu
Copy link
Contributor

zhicwu commented Dec 1, 2022

Finally... But the change has not released yet.

Of course you can contribute. Please use develop branch and add more tests in the pull request.

A few more things you may want to consider:

  • implement ClickHouseDeserializer and ClickHouseSerializer interfaces
  • Use input/output stream instead ByteBuffer
  • extract ClickHouse compatible bitmap implementation and remove RoaringBitmap dedependency - avoid unnecessary byte array copying

@zhicwu zhicwu added this to the 0.4.1 release milestone Jan 19, 2023
@zhicwu zhicwu linked a pull request Feb 19, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment