Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 7 support #12

Open
egesu opened this issue Mar 29, 2020 · 17 comments
Open

Laravel 7 support #12

egesu opened this issue Mar 29, 2020 · 17 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@egesu
Copy link

egesu commented Mar 29, 2020

The package cannot be installed in Laravel 7. Can it work in Laravel 7?

  Problem 1
    - Installation request for chatter-laravel/core ^6 -> satisfiable by chatter-laravel/core[v6.0].
    - Conclusion: remove laravel/framework v7.3.0
    - Conclusion: don't install laravel/framework v7.3.0
    - chatter-laravel/core v6.0 requires laravel/framework ^5.8 || ^6 -> satisfiable by laravel/framework[5.8.x-dev, 6.x-dev].
    - Can only install one of: laravel/framework[5.8.x-dev, v7.3.0].
    - Can only install one of: laravel/framework[6.x-dev, v7.3.0].
    - Installation request for laravel/framework (locked at v7.3.0, required as ^7.0) -> satisfiable by laravel/framework[v7.3.0].
@sbarbat
Copy link
Collaborator

sbarbat commented Mar 30, 2020

Haven't tested yet, would you mind testing it? 🎉

@egesu
Copy link
Author

egesu commented Mar 30, 2020

Sure! But how can I install the package in Laravel 7? I could not find an option in composer to ignore dependencies.

@sbarbat
Copy link
Collaborator

sbarbat commented Apr 2, 2020

@egesu just updated the composer.json file on master to allow Laravel 7, could you check it please? 🎉 👌

@sbarbat sbarbat added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 10, 2020
@sdunayer
Copy link

I tried installing with Laravel 7.6.2 but it won't work because the require for "laravel-frontend-presets/tailwindcss^2.2" which requires Laravel 6. You would have to change the require for the Tailwindcss preset to "^4" as that's the first version that supports Laravel 7. If you can update the composer.json file I can try and install with Laravel 7 again. I am planning on using this for a project despite the challenge that the rest of the project is bootstrap based and this is tailwind based, but it doesn't look like too much trouble to make them both coexist.

@sbarbat
Copy link
Collaborator

sbarbat commented Apr 22, 2020

@sdunayer would you mind doing a PR to master with what you just stated? Atm, master is for Laravel 7 compatibility

@sdunayer
Copy link

In the process of doing that. Turns out you also have to update the version of eloquent-sluggable and after that the whole thing fails in ChatterInstallCommand.php (which probably was not correct as coded anyway but just worked). I'm working on correcting that problem and making sure it will also work in prior Laravel versions. Be a day or two.

@davidjhume
Copy link

Hey, keen to know if anyone has managed to solve this yet as we'd love to use this too, but have the same Laravel 7 compatibility issues! Cheers

@sbarbat
Copy link
Collaborator

sbarbat commented May 11, 2020

Hey @davidjhume, just updated the verison of the tailwindcss presets to the one compatible with Laravel 7 in the master branch. Would you mind testing if it works fine?

@jcrann
Copy link

jcrann commented May 13, 2020

Still not working on Laravel 7 using master branch. If you tell me where to find the errors I can post them.
- Installation request for laravel/framework (locked at v7.11.0, required as ^7.0) -> satisfiable by laravel/framework[v7.11.0]. Installation failed, reverting ./composer.json to its original content.

@davidjhume
Copy link

Hi @sbarbat thanks for getting back to me! We're still evaluating if we need forums, but if we push the button on this we'll definitely test and provide feedback. Cheers

@pro-cms
Copy link

pro-cms commented May 19, 2020

any feedback regarding laravel 7 support

@sdunayer
Copy link

I had started doing some work on this several weeks ago but got sidetracked. While I was finally able to get composer.json updated so that it all installed, it threw an exception because of differences between laravel/ui 1.x and laravel/ui 2.x. I had intended to come up with a way that would work universally (so those using older laravel releases could use the master branch) but I just haven't had the time. Perhaps next week I will get back to it.

@pro-cms
Copy link

pro-cms commented May 22, 2020

I had started doing some work on this several weeks ago but got sidetracked. While I was finally able to get composer.json updated so that it all installed, it threw an exception because of differences between laravel/ui 1.x and laravel/ui 2.x. I had intended to come up with a way that would work universally (so those using older laravel releases could use the master branch) but I just haven't had the time. Perhaps next week I will get back to it.

me too tomorrow I will start working on it, if any of us find the solution, please share with us all

@jcrann
Copy link

jcrann commented May 24, 2020

Thank you very much for working on this, it will be a great fit for my project if we can get it working on Laravel 7.

@jcrann
Copy link

jcrann commented Jun 4, 2020

Anyone have any luck?

@pro-cms

This comment has been minimized.

@magojr
Copy link

magojr commented Sep 7, 2020

Tried to install on laravel 7 (dev-master) => found incompatbility iussue => updated laravel to 7.27.0 => npm dependency warning " prosemirror-utils@0.9.6 requires a peer of prosemirror-tables@^0.9.1 but none is installed. You must install peer dependencies yourself." Installed, no errors but empty (blank) page at the url /forums
Is chatter core dev-master intended to work on Laravel 7 actually?
Anyone can help on this specific isue? (I already tried to downgrade to sass-loader@^7 as explained in issue #17 without luck).
Thank you for any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants