Used std::vector instead of c-style arrays for point storage. #8709
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In case the size is known at compile time, please use |
Nice suggestion, initially i thought of using |
sloriot
reviewed
Jan 22, 2025
| // (0,0), (-1,0), (2,0), (-3,0), ... | ||
| } | ||
|
|
||
| Min_circle mc1( P, P+n, false); // very slow | ||
| Min_circle mc2( P, P+n, true); // fast | ||
| Min_circle mc1( P.begin(), P.begin() + n, false); // very slow |
There was a problem hiding this comment.
Suggested change
| Min_circle mc1( P.begin(), P.begin() + n, false); // very slow | |
| Min_circle mc1( P.begin(), P.end(), false); // very slow |
| Min_circle mc1( P, P+n, false); // very slow | ||
| Min_circle mc2( P, P+n, true); // fast | ||
| Min_circle mc1( P.begin(), P.begin() + n, false); // very slow | ||
| Min_circle mc2( P.begin(), P.begin() +n, true); // fast |
There was a problem hiding this comment.
Suggested change
| Min_circle mc2( P.begin(), P.begin() +n, true); // fast | |
| Min_circle mc2( P.begin(), P.end(), true); // fast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated two CGAL examples to use
std::vectorinstead of plain C-style arrays for storing points.Few more examples can be improved the same way to use
std::vectorand avoid usage of c-style arrays.