Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to the paths of custom scripts in local modules for cloud computing #81

Open
cjjossart opened this issue Aug 3, 2022 · 0 comments

Comments

@cjjossart
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

When running the CDCgov/mycosnp-nf v 1.4 pipeline in the cloud (AWS-Batch through Nextflow-tower) an error is raised due to not being able to find the custom scripts used in local modules (i.e. no such file or directory).
I believe this is happening, because $projectDir is used as part of the file path for these scripts. Locally this would be fine.

Describe the solution you'd like
A clear and concise description of what you want to happen.

A potential solution for this issue could be:

  1. Move all custom scripts to the bin folder, if not there already
    - move scripts and contents of broad-vcf-filter folder up one directory into the bin folder.
  2. Execute scripts by name (i.e. qc_report_stats.py) in local modules instead of using python command and path to script (i.e. $projectDir/bin/qc_report_stats.py).
  3. Update any instances of changed file paths for custom scripts.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

This possible solution works locally and in the cloud with aws-batch.
I can submit a PR with these changes if this makes sense.
Please reach out if there is a better solution to this issue and if there is a reason for the current way the custom scripts are called in local modules.

Thanks and sincerely,

CJ

hseabolt added a commit that referenced this issue Mar 24, 2023
#81 - Standardize scripts to be executable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant