Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zoe] OfferRules.offer is a confusing name #683

Closed
katelynsills opened this issue Mar 13, 2020 · 2 comments
Closed

[Zoe] OfferRules.offer is a confusing name #683

katelynsills opened this issue Mar 13, 2020 · 2 comments
Assignees
Labels
Zoe package: Zoe
Milestone

Comments

@katelynsills
Copy link
Contributor

katelynsills commented Mar 13, 2020

@Chris-Hibbert said:

There's a potential confusion between the offer's rules and the offer clause in the rules. ...we may want to consider renaming one of them.

To explain further, we call the entire structure "offerRules" and offerRules has a key "offer" that is what the person is offering.

Update (3/18):

In this morning's meeting, we decided to retain the name "offer" for the combination of the offerRules, payments, and invite as arguments to zoe.redeem.

We are changing offerRules to proposal.
We are changing offerRules.offer to give
want and exit in the offerRules (now proposal) remain the same.

In summary: A user makes an offer with Zoe. Their offer has a proposal with the following structure:

{
    give: { },
    want: { },
    exit: { },
}

This Issue should be closed in #685

@katelynsills katelynsills added the Zoe package: Zoe label Mar 13, 2020
@Chris-Hibbert
Copy link
Contributor

To be even more explicit, offerRules (currently) have two keys: 'offer' and 'want'. We need a pair of terms, plus a term for the overall structure.

@katelynsills katelynsills added hackathon-release question Further information is requested and removed question Further information is requested labels Mar 18, 2020
@katelynsills katelynsills added this to the Zoe 0.3.0 milestone Mar 18, 2020
@katelynsills katelynsills self-assigned this Mar 19, 2020
@katelynsills
Copy link
Contributor Author

Closed by #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

No branches or pull requests

2 participants