From bd47a0a31787bc22d04da82bacf7376fa8960e91 Mon Sep 17 00:00:00 2001 From: Aliaksei Urbanski Date: Sun, 10 Mar 2024 21:30:33 +0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Remove=20the=20OPENEXR=5FINSTALL?= =?UTF-8?q?=5FEXAMPLES=20CMake=20option?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The OPENEXR_INSTALL_EXAMPLES option is misleading and doesn't have any effect. It might be safely removed in favor of the OPENEXR_BUILD_EXAMPLES option. Co-authored-by: Cary Phillips Signed-off-by: Aliaksei Urbanski --- cmake/OpenEXRSetup.cmake | 3 +-- pyproject.toml | 1 - website/install.rst | 4 ++-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/cmake/OpenEXRSetup.cmake b/cmake/OpenEXRSetup.cmake index f3e84bf984..6f73f28c9b 100644 --- a/cmake/OpenEXRSetup.cmake +++ b/cmake/OpenEXRSetup.cmake @@ -60,8 +60,7 @@ option(OPENEXR_BUILD_LIBS "Enables building of main libraries" ON) option(OPENEXR_BUILD_TOOLS "Enables building of utility programs" ON) option(OPENEXR_INSTALL_TOOLS "Install OpenEXR tools" ON) -option(OPENEXR_BUILD_EXAMPLES "Build OpenEXR examples" ON) -option(OPENEXR_INSTALL_EXAMPLES "Install OpenEXR examples" ON) +option(OPENEXR_BUILD_EXAMPLES "Build and install OpenEXR examples" ON) option(OPENEXR_BUILD_PYTHON "Build python bindings" OFF) diff --git a/pyproject.toml b/pyproject.toml index bd23df333a..7303862b6f 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -46,7 +46,6 @@ metadata.version.provider-path = "./src/wrappers/python" OPENEXR_INSTALL = 'OFF' OPENEXR_BUILD_PYTHON = 'ON' OPENEXR_BUILD_EXAMPLES = 'OFF' -OPENEXR_INSTALL_EXAMPLES = 'OFF' OPENEXR_BUILD_TOOLS = 'OFF' OPENEXR_INSTALL_TOOLS = 'OFF' OPENEXR_INSTALL_PKG_CONFIG = 'OFF' diff --git a/website/install.rst b/website/install.rst index e938313aab..318b2a869c 100644 --- a/website/install.rst +++ b/website/install.rst @@ -460,9 +460,9 @@ Component Options Install the binary programs (exrheader, exrinfo, exrmakepreview, etc). Default is ``ON``. -* ``OPENEXR_INSTALL_EXAMPLES`` +* ``OPENEXR_BUILD_EXAMPLES`` - Build and install the example code. Default is ``ON``. + Build the example code. Default is ``ON``. Additional CMake Options ~~~~~~~~~~~~~~~~~~~~~~~~