Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Turrets with a GuardObject Do Not Gain Score from Destroying Objects (e.g. Auto 3, Auto 5) #147

Open
Hanxven opened this issue Nov 16, 2023 · 1 comment
Labels
inaccuracy Tested stat related inconsistencies between a real diep server this replica

Comments

@Hanxven
Copy link

Hanxven commented Nov 16, 2023

A possible workaround is to modify the onKill method of class AutoTurrent in AutoTurrent.ts:

public onKill(killedEntity: LivingEntity) {
    if (!(this.owner instanceof LivingEntity) && !(this.owner instanceof GuardObject)) return;
    this.owner.onKill(killedEntity); // GuardObjet.onKill -> TankBody.onKill -> add score
}

The reason for this change is that the GuardObject, serving as the rotation base, is not a LivingEntity.

@Hanxven Hanxven added the inaccuracy Tested stat related inconsistencies between a real diep server this replica label Nov 16, 2023
@Nul-led
Copy link
Collaborator

Nul-led commented Nov 16, 2023

Nice catch, feel free to make a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inaccuracy Tested stat related inconsistencies between a real diep server this replica
Projects
None yet
Development

No branches or pull requests

2 participants